netdev - Re: [PATCH net-next 1/2] net: bridge: multicast: re-implement port multicast enable/disable functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202412220334.lMkjQPYn-lkp@intel.com>
Date: Sun, 22 Dec 2024 03:59:42 +0800
From: kernel test robot <lkp@...el.com>
To: Yong Wang <yongwang@...dia.com>, razor@...ckwall.org, roopa@...dia.com,
	davem@...emloft.net, edumazet@...gle.com, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, aroulin@...dia.com, idosch@...dia.com,
	nmiyar@...dia.com
Subject: Re: [PATCH net-next 1/2] net: bridge: multicast: re-implement port
 multicast enable/disable functions

Hi Yong,

kernel test robot noticed the following build errors:

[auto build test ERROR on 3272040790eb4b6cafe6c30ec05049e9599ec456]

url:    https://github.com/intel-lab-lkp/linux/commits/Yong-Wang/net-bridge-multicast-re-implement-port-multicast-enable-disable-functions/20241221-060848
base:   3272040790eb4b6cafe6c30ec05049e9599ec456
patch link:    https://lore.kernel.org/r/20241220220604.1430728-2-yongwang%40nvidia.com
patch subject: [PATCH net-next 1/2] net: bridge: multicast: re-implement port multicast enable/disable functions
config: nios2-randconfig-r071-20241221 (https://download.01.org/0day-ci/archive/20241222/202412220334.lMkjQPYn-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241222/202412220334.lMkjQPYn-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412220334.lMkjQPYn-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/bridge/br_multicast.c: In function 'br_multicast_toggle_port':
>> net/bridge/br_multicast.c:2178:35: error: implicit declaration of function 'br_vlan_state_allowed' [-Wimplicit-function-declaration]
    2178 |                         if (on && br_vlan_state_allowed(br_vlan_get_state(vlan), true))
         |                                   ^~~~~~~~~~~~~~~~~~~~~
>> net/bridge/br_multicast.c:2178:57: error: implicit declaration of function 'br_vlan_get_state'; did you mean 'br_vlan_get_stats'? [-Wimplicit-function-declaration]
    2178 |                         if (on && br_vlan_state_allowed(br_vlan_get_state(vlan), true))
         |                                                         ^~~~~~~~~~~~~~~~~
         |                                                         br_vlan_get_stats


vim +/br_vlan_state_allowed +2178 net/bridge/br_multicast.c

  2159	
  2160	static void br_multicast_toggle_port(struct net_bridge_port *port, bool on)
  2161	{
  2162		struct net_bridge *br = port->br;
  2163	
  2164		if (br_opt_get(br, BROPT_MCAST_VLAN_SNOOPING_ENABLED)) {
  2165			struct net_bridge_vlan_group *vg;
  2166			struct net_bridge_vlan *vlan;
  2167	
  2168			rcu_read_lock();
  2169			vg = nbp_vlan_group_rcu(port);
  2170			if (!vg) {
  2171				rcu_read_unlock();
  2172				return;
  2173			}
  2174	
  2175			/* iterate each vlan of the port, toggle port_mcast_ctx per vlan */
  2176			list_for_each_entry_rcu(vlan, &vg->vlan_list, vlist) {
  2177				/* enable port_mcast_ctx when vlan is LEARNING or FORWARDING */
> 2178				if (on && br_vlan_state_allowed(br_vlan_get_state(vlan), true))
  2179					br_multicast_enable_port_ctx(&vlan->port_mcast_ctx);
  2180				else
  2181					br_multicast_disable_port_ctx(&vlan->port_mcast_ctx);
  2182			}
  2183			rcu_read_unlock();
  2184		} else {
  2185			/* use the port's multicast context when vlan snooping is disabled */
  2186			if (on)
  2187				br_multicast_enable_port_ctx(&port->multicast_ctx);
  2188			else
  2189				br_multicast_disable_port_ctx(&port->multicast_ctx);
  2190		}
  2191	}
  2192	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki