netdev - Re: [PATCH net-next v3 2/2] net: bridge: add skb drop reasons to the most common drop points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f42d495f-abd3-4f8a-b647-ddebe2e6249d@blackwall.org>
Date: Sun, 22 Dec 2024 11:46:34 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Radu Rendec <rrendec@...hat.com>, Ido Schimmel <idosch@...sch.org>,
 Roopa Prabhu <roopa@...dia.com>
Cc: bridge@...ts.linux.dev, netdev@...r.kernel.org,
 Simon Horman <horms@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v3 2/2] net: bridge: add skb drop reasons to the
 most common drop points

On 12/19/24 18:36, Radu Rendec wrote:
> The bridge input code may drop frames for various reasons and at various
> points in the ingress handling logic. Currently kfree_skb() is used
> everywhere, and therefore no drop reason is specified. Add drop reasons
> to the most common drop points.
> 
> Drop reasons are not added exhaustively to the entire bridge code. The
> intention is to incrementally add drop reasons to the rest of the bridge
> code in follow up patches.
> 
> Signed-off-by: Radu Rendec <rrendec@...hat.com>
> ---
>  include/net/dropreason-core.h | 12 ++++++++++++
>  net/bridge/br_forward.c       | 16 ++++++++++++----
>  net/bridge/br_input.c         | 20 +++++++++++++++-----
>  3 files changed, 39 insertions(+), 9 deletions(-)
> 

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>