netdev - Re: [PATCH net-next V4 01/11] net/mlx5: LAG, Refactor lag logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241223103201.65a46a7a@kernel.org>
Date: Mon, 23 Dec 2024 10:32:01 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, <netdev@...r.kernel.org>, Saeed Mahameed
 <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>, Leon Romanovsky
 <leonro@...dia.com>, Mark Bloch <mbloch@...dia.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, "Rongwei Liu" <rongweil@...dia.com>
Subject: Re: [PATCH net-next V4 01/11] net/mlx5: LAG, Refactor lag logic

On Thu, 19 Dec 2024 19:58:31 +0200 Tariq Toukan wrote:
> @@ -88,13 +86,13 @@ static int mlx5_lag_create_port_sel_table(struct mlx5_lag *ldev,
>  								      &dest, 1);
>  			if (IS_ERR(lag_definer->rules[idx])) {
>  				err = PTR_ERR(lag_definer->rules[idx]);
> -				do {
> +				mlx5_ldev_for_each_reverse(k, i, 0, ldev) {
>  					while (j--) {
> -						idx = i * ldev->buckets + j;
> +						idx = k * ldev->buckets + j;
>  						mlx5_del_flow_rules(lag_definer->rules[idx]);
>  					}
>  					j = ldev->buckets;
> -				} while (i--);
> +				};

stray semicolon, please follow up

>  				goto destroy_fg;
>  			}