netdev - Re: [PATCH net] net: pse-pd: tps23881: Fix power on/off issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2kBx0ePtnLKMuiA@pengutronix.de>
Date: Mon, 23 Dec 2024 07:23:03 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net] net: pse-pd: tps23881: Fix power on/off issue

On Fri, Dec 20, 2024 at 06:04:00PM +0100, Kory Maincent wrote:
> An issue was present in the initial driver implementation. The driver
> read the power status of all channels before toggling the bit of the
> desired one. Using the power status register as a base value introduced
> a problem, because only the bit corresponding to the concerned channel ID
> should be set in the write-only power enable register. This led to cases
> where disabling power for one channel also powered off other channels.
> 
> This patch removes the power status read and ensures the value is
> limited to the bit matching the channel index of the PI.
> 
> Fixes: 20e6d190ffe1 ("net: pse-pd: Add TI TPS23881 PSE controller driver")
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>

Acked-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you!
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |