| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202412231605.tOclyr7m-lkp@intel.com>
Date: Mon, 23 Dec 2024 16:19:31 +0800
From: kernel test robot <lkp@...el.com>
To: John Daley <johndale@...co.com>, benve@...co.com, satishkh@...co.com,
andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
John Daley <johndale@...co.com>,
Nelson Escobar <neescoba@...co.com>
Subject: Re: [PATCH net-next 4/5] enic: Use the Page Pool API for RX when MTU
is less than page size
Hi John,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/John-Daley/enic-Refactor-RX-path-common-code-into-helper-functions/20241221-055423
base: net-next/main
patch link: https://lore.kernel.org/r/20241220215058.11118-5-johndale%40cisco.com
patch subject: [PATCH net-next 4/5] enic: Use the Page Pool API for RX when MTU is less than page size
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241223/202412231605.tOclyr7m-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241223/202412231605.tOclyr7m-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412231605.tOclyr7m-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/net/ethernet/cisco/enic/enic_rq.c:4:
In file included from include/linux/skbuff.h:17:
In file included from include/linux/bvec.h:10:
In file included from include/linux/highmem.h:8:
In file included from include/linux/cacheflush.h:5:
In file included from arch/x86/include/asm/cacheflush.h:5:
In file included from include/linux/mm.h:2223:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/cisco/enic/enic_rq.c:214:30: warning: variable 'q_number' is uninitialized when used here [-Wuninitialized]
214 | enic->netdev->name, q_number);
| ^~~~~~~~
include/linux/net.h:286:43: note: expanded from macro 'net_warn_ratelimited'
286 | net_ratelimited_function(pr_warn, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/net.h:272:12: note: expanded from macro 'net_ratelimited_function'
272 | function(__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:554:37: note: expanded from macro 'pr_warn'
554 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:501:60: note: expanded from macro 'printk'
501 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:473:19: note: expanded from macro 'printk_index_wrap'
473 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/net/ethernet/cisco/enic/enic_rq.c:204:14: note: initialize the variable 'q_number' to silence this warning
204 | u16 q_number, completed_index, bytes_written, vlan_tci, checksum;
| ^
| = 0
5 warnings generated.
vim +/q_number +214 drivers/net/ethernet/cisco/enic/enic_rq.c
189
190 void enic_rq_indicate_page(struct vnic_rq *vrq, struct cq_desc *cq_desc,
191 struct vnic_rq_buf *buf, int skipped, void *opaque)
192 {
193 struct enic *enic = vnic_dev_priv(vrq->vdev);
194 struct sk_buff *skb;
195 struct enic_rq *rq = &enic->rq[vrq->index];
196 struct enic_rq_stats *rqstats = &rq->stats;
197 struct vnic_cq *cq = &enic->cq[enic_cq_rq(enic, vrq->index)];
198 struct napi_struct *napi;
199 u8 type, color, eop, sop, ingress_port, vlan_stripped;
200 u8 fcoe, fcoe_sof, fcoe_fc_crc_ok, fcoe_enc_error, fcoe_eof;
201 u8 tcp_udp_csum_ok, udp, tcp, ipv4_csum_ok;
202 u8 ipv6, ipv4, ipv4_fragment, fcs_ok, rss_type, csum_not_calc;
203 u8 packet_error;
204 u16 q_number, completed_index, bytes_written, vlan_tci, checksum;
205 u32 rss_hash;
206
207 if (skipped) {
208 rqstats->desc_skip++;
209 return;
210 }
211
212 if (!buf || !buf->dma_addr) {
213 net_warn_ratelimited("%s[%u]: !buf || !buf->dma_addr!!\n",
> 214 enic->netdev->name, q_number);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists