netdev - Re: [net v3] net: wwan: t7xx: Fix FSM command timeout issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA4E0537-84FE-4E1A-8BB6-7636D3799E39@gmail.com>
Date: Tue, 24 Dec 2024 09:55:00 +0200
From: Sergey Ryazanov <ryazanov.s.a@...il.com>
To: Jinjian Song <jinjian.song@...ocom.com>, chandrashekar.devegowda@...el.com,
 chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com,
 m.chetan.kumar@...ux.intel.com, ricardo.martinez@...ux.intel.com,
 loic.poulain@...aro.org, johannes@...solutions.net, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
CC: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 linux-doc@...r.kernel.org, angelogioacchino.delregno@...labora.com,
 linux-arm-kernel@...ts.infradead.org, matthias.bgg@...il.com, corbet@....net,
 linux-mediatek@...ts.infradead.org, helgaas@...nel.org,
 danielwinkler@...gle.com, korneld@...gle.com, andrew+netdev@...n.ch,
 horms@...nel.org
Subject: Re: [net v3] net: wwan: t7xx: Fix FSM command timeout issue

On December 24, 2024 6:15:52 AM GMT+02:00, Jinjian Song <jinjian.song@...ocom.com> wrote:
>When driver processes the internal state change command, it use an
>asynchronous thread to process the command operation. If the main
>thread detects that the task has timed out, the asynchronous thread
>will panic when executing the completion notification because the
>main thread completion object has been released.
>
>BUG: unable to handle page fault for address: fffffffffffffff8
>PGD 1f283a067 P4D 1f283a067 PUD 1f283c067 PMD 0
>Oops: 0000 [#1] PREEMPT SMP NOPTI
>RIP: 0010:complete_all+0x3e/0xa0
>[...]
>Call Trace:
> <TASK>
> ? __die_body+0x68/0xb0
> ? page_fault_oops+0x379/0x3e0
> ? exc_page_fault+0x69/0xa0
> ? asm_exc_page_fault+0x22/0x30
> ? complete_all+0x3e/0xa0
> fsm_main_thread+0xa3/0x9c0 [mtk_t7xx (HASH:1400 5)]
> ? __pfx_autoremove_wake_function+0x10/0x10
> kthread+0xd8/0x110
> ? __pfx_fsm_main_thread+0x10/0x10 [mtk_t7xx (HASH:1400 5)]
> ? __pfx_kthread+0x10/0x10
> ret_from_fork+0x38/0x50
> ? __pfx_kthread+0x10/0x10
> ret_from_fork_asm+0x1b/0x30
> </TASK>
>[...]
>CR2: fffffffffffffff8
>---[ end trace 0000000000000000 ]---
>
>Use the reference counter to ensure safe release as Sergey suggests:
>https://lore.kernel.org/all/da90f64c-260a-4329-87bf-1f9ff20a5951@gmail.com/
>
>Fixes: 13e920d93e37 ("net: wwan: t7xx: Add core components")
>Signed-off-by: Jinjian Song <jinjian.song@...ocom.com>

Acked-by: Sergey Ryazanov <ryazanov.s.a@...il.com>