[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <69033618-a872-1c3a-3f28-552603cedd8e@amd.com>
Date: Fri, 27 Dec 2024 08:08:45 +0000
From: Alejandro Lucero Palau <alucerop@....com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
alejandro.lucero-palau@....com
Cc: linux-cxl@...r.kernel.org, netdev@...r.kernel.org,
dan.j.williams@...el.com, martin.habets@...inx.com, edward.cree@....com,
davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
edumazet@...gle.com, dave.jiang@...el.com
Subject: Re: [PATCH v8 11/27] cxl: add function for setting media ready by a
driver
On 12/24/24 17:29, Jonathan Cameron wrote:
> On Mon, 16 Dec 2024 16:10:26 +0000
> alejandro.lucero-palau@....com wrote:
>
>> From: Alejandro Lucero <alucerop@....com>
>>
>> A Type-2 driver may be required to set the memory availability explicitly,
>> for example because there is not a mailbox for doing so through a specific
>> command.
>>
>> Add a function to the exported CXL API for accelerator drivers having this
>> possibility.
>>
>> Signed-off-by: Alejandro Lucero <alucerop@....com>
>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>> Reviewed-by: Ben Cheatham <benjamin.cheatham@....com>
> I wonder if it is worth capturing the reasoning for this a comment?
Sorry, I can not understand this.
> Either way
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>
>> ---
>> drivers/cxl/core/memdev.c | 6 ++++++
>> include/cxl/cxl.h | 1 +
>> 2 files changed, 7 insertions(+)
>>
>> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
>> index c414b0fbbead..82c354b1375e 100644
>> --- a/drivers/cxl/core/memdev.c
>> +++ b/drivers/cxl/core/memdev.c
>> @@ -789,6 +789,12 @@ int cxl_release_resource(struct cxl_dev_state *cxlds, enum cxl_resource type)
>> }
>> EXPORT_SYMBOL_NS_GPL(cxl_release_resource, "CXL");
>>
>> +void cxl_set_media_ready(struct cxl_dev_state *cxlds)
>> +{
>> + cxlds->media_ready = true;
>> +}
>> +EXPORT_SYMBOL_NS_GPL(cxl_set_media_ready, "CXL");
>> +
>> static int cxl_memdev_release_file(struct inode *inode, struct file *file)
>> {
>> struct cxl_memdev *cxlmd =
>> diff --git a/include/cxl/cxl.h b/include/cxl/cxl.h
>> index 44664c9928a4..473128fdfb22 100644
>> --- a/include/cxl/cxl.h
>> +++ b/include/cxl/cxl.h
>> @@ -44,4 +44,5 @@ bool cxl_pci_check_caps(struct cxl_dev_state *cxlds,
>> int cxl_pci_accel_setup_regs(struct pci_dev *pdev, struct cxl_dev_state *cxlds);
>> int cxl_request_resource(struct cxl_dev_state *cxlds, enum cxl_resource type);
>> int cxl_release_resource(struct cxl_dev_state *cxlds, enum cxl_resource type);
>> +void cxl_set_media_ready(struct cxl_dev_state *cxlds);
>> #endif
Powered by blists - more mailing lists