netdev - Re: [PATCH net-next v2 5/5] enic: Obtain the Link speed only after the link comes up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c476e255-586a-45e7-9b86-39c127bacd37@lunn.ch>
Date: Fri, 27 Dec 2024 16:59:42 +0100
From: Andrew Lunn <andrew@...n.ch>
To: John Daley <johndale@...co.com>
Cc: benve@...co.com, satishkh@...co.com, andrew+netdev@...n.ch,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	Nelson Escobar <neescoba@...co.com>
Subject: Re: [PATCH net-next v2 5/5] enic: Obtain the Link speed only after
 the link comes up

On Thu, Dec 26, 2024 at 07:14:10PM -0800, John Daley wrote:
> The link speed that is used to index the table of minimum RX adaptive
> coalescing values is incorrect because the link speed was being checked
> before the link was up. Change the adaptive RX coalescing setup function
> to run after the Link comes up.
> 
> There could be a minor bandwidth impact when adaptive interrupts were
> enabled. The low end of the adaptive interrupt range was being set to 0
> for all packets instead of 3us for packets less the 1000 bytes and 6us
> for larger packet for link speeds greater

There are two changes here, so please break it into two patches.

> +++ b/drivers/net/ethernet/cisco/enic/enic_main.c
> @@ -84,6 +84,8 @@ MODULE_AUTHOR("Scott Feldman <scofeldm@...co.com>");
>  MODULE_LICENSE("GPL");
>  MODULE_DEVICE_TABLE(pci, enic_id_table);
>  
> +static void enic_set_rx_coal_setting(struct enic *enic);
> +

Please don't add forward declarations. Move the code around
instead. You can add a preparation patch which does the move, and in
the commit message say there is no functional change. That makes is
quick and easy to review.

      
    Andrew

---
pw-bot: cr