netdev - Re: [PATCH net-next] devlink: Improve the port attributes description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241227101924.48a12733@kernel.org>
Date: Fri, 27 Dec 2024 10:19:24 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Parav Pandit <parav@...dia.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "jiri@...nulli.us"
 <jiri@...nulli.us>, "davem@...emloft.net" <davem@...emloft.net>,
 "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com"
 <pabeni@...hat.com>, "horms@...nel.org" <horms@...nel.org>, Shay Drori
 <shayd@...dia.com>, Mark Bloch <mbloch@...dia.com>, Jiri Pirko
 <jiri@...dia.com>
Subject: Re: [PATCH net-next] devlink: Improve the port attributes
 description

On Tue, 24 Dec 2024 03:40:34 +0000 Parav Pandit wrote:
> > On Thu, 19 Dec 2024 17:01:58 +0200 Parav Pandit wrote:  
> > > Improve the description of devlink port attributes PF, VF and SF
> > > numbers.  
> > 
> > Please provide more context. It's not obvious why you remove PF from
> > descriptions but not VF or SF.  
> 
> 'PF number' was vague and source of confusion. Some started thinking that it is some kind of index like how VF number is an index.
> So 'PF number' is rewritten to bring the clarity that it's the function number of the PCI device which is very will described in the PCI spec.

Just to make sure I understand - you're trying to emphasize that 
the PF number is just an arbitrary ID of the PCIe PF within the chip, 
not necessarily related to any BDF numbering sequence?

If that's the case I think the motivation makes sense. But IMHO
the execution is not ideal, I offer the fact we're having this
exchange as a proof of the point not getting across :(

May be better to explain this in a couple of sentences somewhere
(actually I get the feeling we already have such an explanation
but I can't find it. Perhaps it was just talked about on the list)
and then just point to that longer explanation in the attr kdocs?

> For VF number, the description is added describing it's an index starting from 0 (unlike pci spec where vf number starts from 1).
> SF number is user supplied number so nothing to remove there.

nit: -EOUTLOOK.. please wrap the lines in your replies at 80 chars.