netdev - Re: [PATCH] eth: fbnic: Avoid garbage value in fbnic_mac_get_sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241227105630.19ab7e3c@kernel.org>
Date: Fri, 27 Dec 2024 10:56:30 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Su Hui <suhui@...china.com>
Cc: alexanderduyck@...com, kernel-team@...a.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 sanmanpradhan@...a.com, mohsin.bashr@...il.com,
 kalesh-anakkur.purayil@...adcom.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] eth: fbnic: Avoid garbage value in
 fbnic_mac_get_sensor_asic()

On Tue, 24 Dec 2024 10:27:29 +0800 Su Hui wrote:
> 'fw_cmpl' is uninitialized which makes 'sensor' and '*val' to be stored
> garbage value. Initialize 'fw_cmpl' with 'fdb->cmpl_data' to fix this
> problem.

Argh, this function should send a FW command to read the sensors, 
it does nothing today :/ Looks like an upstreaming fail..

If you'd like to fix this please just remove the body of the function
entirely and return -EOPNOTSUPP. We'll have to follow up in net-next
to fill in the gaps in sensor reading.
-- 
pw-bot: cr