netdev - Re: [PATCH v1 02/16] net-next/yunsilicon: Enable CMDQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <a9c75ef6-88fe-4cf5-9d27-22c3ba153ac5@yunsilicon.com>
Date: Fri, 27 Dec 2024 11:52:05 +0800
From: "tianx" <tianx@...silicon.com>
To: "Przemek Kitszel" <przemyslaw.kitszel@...el.com>
Cc: <andrew+netdev@...n.ch>, <kuba@...nel.org>, <netdev@...r.kernel.org>, 
	<pabeni@...hat.com>, <edumazet@...gle.com>, <davem@...emloft.net>, 
	<jeff.johnson@....qualcomm.com>, <weihg@...silicon.com>, 
	<wanry@...silicon.com>
Subject: Re: [PATCH v1 02/16] net-next/yunsilicon: Enable CMDQ

>> +     * complete and we may need to increase this timeout value
>> +     */
>> +    XSC_CMD_TIMEOUT_MSEC    = 10 * 1000,
>> +    XSC_CMD_WQ_MAX_NAME    = 32,
>
> take a look at the abundant kernel provided work queues, not need to
> spawn your own most of the time
>
>
Hi, Przemek

Thank you for the detailed review. The previous issues will be addressed 
in v2, but this one needs clarification.

We need a workqueue that executes tasks sequentially, but the workqueues 
provided by the kernel do not meet this requirement, so we used 
|create_singlethread_workqueue| to create one.

Best regards,

Xin