netdev - Re: [PATCH net]: bcmsysport: fix call balance of priv->clk handling routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <629cb86f-0484-4ce3-8847-06abaa9c41ab@broadcom.com>
Date: Mon, 30 Dec 2024 11:14:57 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Vitalii Mordan <mordan@...ras.ru>
Cc: Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, Fedor Pchelkin <pchelkin@...ras.ru>,
 Alexey Khoroshilov <khoroshilov@...ras.ru>, Vadim Mutilin <mutilin@...ras.ru>
Subject: Re: [PATCH net]: bcmsysport: fix call balance of priv->clk handling
 routines

On 12/27/24 04:30, Vitalii Mordan wrote:
> Check the return value of clk_prepare_enable to ensure that priv->clk has
> been successfully enabled.
> 
> If priv->clk was not enabled during bcm_sysport_probe, bcm_sysport_resume,
> or bcm_sysport_open, it must not be disabled in any subsequent execution
> paths.
> 
> Found by Linux Verification Center (linuxtesting.org) with Klever.
> 
> Fixes: 31bc72d97656 ("net: systemport: fetch and use clock resources")
> Signed-off-by: Vitalii Mordan <mordan@...ras.ru>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian