netdev - Re: [PATCH v4 4/7] can: Add Nuvoton NCT6694 CAN support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <41f77d39-bce3-4e3b-98c8-f248b723a24c@wanadoo.fr>
Date: Mon, 30 Dec 2024 14:56:09 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Ming Yu <a0282524688@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-rtc@...r.kernel.org, tmyu0@...oton.com,
 lee@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl,
 andi.shyti@...nel.org, mkl@...gutronix.de, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, wim@...ux-watchdog.org, linux@...ck-us.net,
 jdelvare@...e.com, alexandre.belloni@...tlin.com
Subject: Re: [PATCH v4 4/7] can: Add Nuvoton NCT6694 CAN support

On 27/12/2024 at 18:57, Ming Yu wrote:
> This driver supports Socket CANfd functionality for NCT6694 MFD
> device based on USB interface.
> 
> Signed-off-by: Ming Yu <a0282524688@...il.com>
> ---

(...)

> +config CAN_NCT6694
> +	tristate "Nuvoton NCT6694 Socket CANfd support"
> +	depends on MFD_NCT6694

I think it would be better to do a

	select MFD_NCT6694

here.

Then, make MFD_NCT6694 an hidden configuration in a similar fashion as
MFD_CORE. Alone, CONFIG_MFD_NCT6694 does nothing, so better to hide it
from the end user.

The comment also applies to the other patches.

> +	help
> +	  If you say yes to this option, support will be included for Nuvoton
> +	  NCT6694, a USB device to socket CANfd controller.
> +
> +	  This driver can also be built as a module. If so, the module will
> +	  be called nct6694_canfd.
> +

(...)

Yours sincerely,
Vincent Mailhol