netdev - RE: [PATCH v6 net-next 11/14] virtio_net: Accurate ECN flag in virtio_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR07MB79849952690901A50688EFEDA3092@PAXPR07MB7984.eurprd07.prod.outlook.com>
Date: Mon, 30 Dec 2024 09:50:59 +0000
From: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
To: Jason Wang <jasowang@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "dsahern@...il.com"
	<dsahern@...il.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "dsahern@...nel.org"
	<dsahern@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"joel.granados@...nel.org" <joel.granados@...nel.org>, "kuba@...nel.org"
	<kuba@...nel.org>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"horms@...nel.org" <horms@...nel.org>, "pablo@...filter.org"
	<pablo@...filter.org>, "kadlec@...filter.org" <kadlec@...filter.org>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"coreteam@...filter.org" <coreteam@...filter.org>, "shenjian15@...wei.com"
	<shenjian15@...wei.com>, "salil.mehta@...wei.com" <salil.mehta@...wei.com>,
	"shaojijie@...wei.com" <shaojijie@...wei.com>, "saeedm@...dia.com"
	<saeedm@...dia.com>, "tariqt@...dia.com" <tariqt@...dia.com>,
	"mst@...hat.com" <mst@...hat.com>, "xuanzhuo@...ux.alibaba.com"
	<xuanzhuo@...ux.alibaba.com>, "eperezma@...hat.com" <eperezma@...hat.com>,
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>,
	"ij@...nel.org" <ij@...nel.org>, "ncardwell@...gle.com"
	<ncardwell@...gle.com>, "Koen De Schepper (Nokia)"
	<koen.de_schepper@...ia-bell-labs.com>, "g.white@...lelabs.com"
	<g.white@...lelabs.com>, "ingemar.s.johansson@...csson.com"
	<ingemar.s.johansson@...csson.com>, "mirja.kuehlewind@...csson.com"
	<mirja.kuehlewind@...csson.com>, "cheshire@...le.com" <cheshire@...le.com>,
	"rs.ietf@....at" <rs.ietf@....at>, "Jason_Livingood@...cast.com"
	<Jason_Livingood@...cast.com>, "vidhi_goel@...le.com" <vidhi_goel@...le.com>
Subject: RE: [PATCH v6 net-next 11/14] virtio_net: Accurate ECN flag in
 virtio_net_hdr

>From: Jason Wang <jasowang@...hat.com> 
>Sent: Monday, December 30, 2024 8:52 AM
>To: Chia-Yu Chang (Nokia) <chia-yu.chang@...ia-bell-labs.com>
>Cc: netdev@...r.kernel.org; dsahern@...il.com; davem@...emloft.net; edumazet@...gle.com; dsahern@...nel.org; pabeni@...hat.com; joel.granados@...nel.org; kuba@...nel.org; andrew+netdev@...n.ch; horms@...nel.org; pablo@...filter.org; kadlec@...filter.org; netfilter-devel@...r.kernel.org; coreteam@...filter.org; shenjian15@...wei.com; salil.mehta@...wei.com; shaojijie@...wei.com; saeedm@...dia.com; tariqt@...dia.com; mst@...hat.com; xuanzhuo@...ux.alibaba.com; eperezma@...hat.com; virtualization@...ts.linux.dev; ij@...nel.org; ncardwell@...gle.com; Koen De Schepper (Nokia) <koen.de_schepper@...ia-bell-labs.com>; g.white@...lelabs.com; ingemar.s.johansson@...csson.com; mirja.kuehlewind@...csson.com; cheshire@...le.com; rs.ietf@....at; Jason_Livingood@...cast.com; vidhi_goel@...le.com
>Subject: Re: [PATCH v6 net-next 11/14] virtio_net: Accurate ECN flag in virtio_net_hdr
>
>[You don't often get email from jasowang@...hat.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
>CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
>
>
>
>On Sat, Dec 28, 2024 at 3:13 AM <chia-yu.chang@...ia-bell-labs.com> wrote:
>>
>> From: Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
>>
>> Unlike RFC 3168 ECN, accurate ECN uses the CWR flag as part of the ACE 
>> field to count new packets with CE mark; however, it will be corrupted 
>> by the RFC 3168 ECN-aware TSO. Therefore, fallback shall be applied by 
>> seting NETIF_F_GSO_ACCECN to ensure that the CWR flag should not be 
>> changed within a super-skb.
>>
>> To apply the aforementieond new AccECN GSO for virtio, new featue bits 
>> for host and guest are added for feature negotiation between driver 
>> and device. And the translation of Accurate ECN GSO flag between 
>> virtio_net_hdr and skb header for NETIF_F_GSO_ACCECN is also added to 
>> avoid CWR flag corruption due to RFC3168 ECN TSO.
>>
>> Signed-off-by: Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
>> ---
>>  drivers/net/virtio_net.c        | 14 +++++++++++---
>>  drivers/vdpa/pds/debugfs.c      |  6 ++++++
>>  include/linux/virtio_net.h      | 16 ++++++++++------
>>  include/uapi/linux/virtio_net.h |  5 +++++
>>  4 files changed, 32 insertions(+), 9 deletions(-)
>
>Is there a link to the spec patch? It needs to be accepted first.
>
>Thanks

Hi Jason,

Thanks for the feedback, I found the virtio-spec in github: https://github.com/oasis-tcs/virtio-spec but not able to find the procedure to propose.
Could you help to share the procedure to propose spec patch? Thanks.

--
Chia-Yu