netdev - Re: [PATCH] net: netpoll: ensure skb_pool list is always initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241230175707.5e18ae96@kernel.org>
Date: Mon, 30 Dec 2024 17:57:07 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: John Sperbeck <jsperbeck@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, Simon Horman <horms@...nel.org>, Breno Leitao
 <leitao@...ian.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: netpoll: ensure skb_pool list is always
 initialized

On Sat, 21 Dec 2024 17:23:34 -0800 John Sperbeck wrote:
> Move the skb_pool list initialization into __netpoll_setup().  Also,
> have netpoll_setup() call this before allocating its initial pool of
> packets.
> 
> Fixes: 6c59f16f1770 ("net: netpoll: flush skb pool during cleanup")

The fixes tag seems to be off by one? Wasn't the problem was introduced
by commit 221a9c1df790 ("net: netpoll: Individualize the skb pool") ?

Since __netpoll_setup() can be called by other drivers, shouldn't 
we move refill in there? Since the pool is per np?

Optionally, could you extend the netcons tests to exercise netcons over
vlan? I think it should be able to trigger the crash you're fixing?
-- 
pw-bot: cr