netdev - Re: [PATCH net-next v16 26/26] testing/selftests: add test tool and scripts for ovpn module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97f8ebf1-bdea-4084-aadd-360d02d00d85@openvpn.net>
Date: Tue, 31 Dec 2024 08:42:11 +0100
From: Antonio Quartulli <antonio@...nvpn.net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Donald Hunter <donald.hunter@...il.com>,
 Shuah Khan <shuah@...nel.org>, sd@...asysnail.net, ryazanov.s.a@...il.com,
 Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Xiao Liang <shaw.leon@...il.com>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH net-next v16 26/26] testing/selftests: add test tool and
 scripts for ovpn module

On 20/12/24 05:02, Jakub Kicinski wrote:
> On Thu, 19 Dec 2024 02:42:20 +0100 Antonio Quartulli wrote:
>> +uint64_t nla_get_uint(struct nlattr *attr)
>> +{
>> +	if (nla_len(attr) == sizeof(uint32_t))
>> +		return nla_get_u32(attr);
>> +	else
>> +		return nla_get_u64(attr);
>> +}
> 
> Fedora 41 has: libnl3 3.11.0
> which already defines nla_get_uint()
> 
> ovpn-cli.c:46:10: error: conflicting types for ‘nla_get_uint’; have ‘uint64_t(struct nlattr *)’ {aka ‘long unsigned int(struct nlattr *)’}
>     46 | uint64_t nla_get_uint(struct nlattr *attr)
>        |          ^~~~~~~~~~~~
> In file included from /usr/include/libnl3/netlink/msg.h:11,
>                   from /usr/include/libnl3/netlink/genl/genl.h:10,
>                   from ovpn-cli.c:26:
> /usr/include/libnl3/netlink/attr.h:126:25: note: previous declaration of ‘nla_get_uint’ with type ‘uint64_t(const struct nlattr *)’ {aka ‘long unsigned int(const struct nlattr *)’}
>    126 | extern uint64_t         nla_get_uint(const struct nlattr *);
>        |                         ^~~~~~~~~~~~

dang!
I guess I will just rename this function to avoid the clash for the time 
being.

Thanks.

Regards,

-- 
Antonio Quartulli
OpenVPN Inc.