netdev - Re: [PATCH v2] netfilter: uapi: Merge xt_*.h/c and ipt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31331e58-bc0a-427b-8528-52448764a91e@lunn.ch>
Date: Thu, 2 Jan 2025 21:22:34 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Szőke Benjamin <egyszeregy@...email.hu>
Cc: fw@...len.de, pablo@...filter.org, lorenzo@...nel.org,
	daniel@...earbox.net, leitao@...ian.org, amiculas@...co.com,
	kadlec@...filter.org, davem@...emloft.net, dsahern@...nel.org,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, netfilter-devel@...r.kernel.org,
	coreteam@...filter.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] netfilter: uapi: Merge xt_*.h/c and ipt_*.h which has
 same name.

On Thu, Jan 02, 2025 at 07:53:36PM +0100, Szőke Benjamin wrote:
> 2025. 01. 02. 18:39 keltezéssel, Andrew Lunn írta:
> > On Thu, Jan 02, 2025 at 06:21:15PM +0100, egyszeregy@...email.hu wrote:
> > > From: Benjamin Szőke <egyszeregy@...email.hu>
> > > 
> > > Merge and refactoring xt_*.h, xt_*.c and ipt_*.h files which has the same
> > > name in upper and lower case format. Combining these modules should provide
> > > some decent memory savings.
> > 
> > Numbers please. We don't normally accept optimisations without some
> > form of benchmark showing there is an improvement.
> 
> Some of you mentioned in a reply e-mail, that is a good benefits in merging
> the codes. I do not have test result about it and i will no provide it.

Try looking at the man page of size(1).

> > > The goal is to fix Linux repository for case-insensitive filesystem,
> > > to able to clone it and editable on any operating systems.
> > 
> > This needs a much stronger argument, since as i already pointed out,
> > how many case-insenstive file systems are still in use? Please give
> > real world examples of why this matters.
> > 
> 
> All of MacOS and Windows platform are case-insensitive.

Windows is generally case magic, not case insensitive. When opening a
file it will first try to be case sensitive, if that fails, it tries
case insensitive, in order to be backwards compatible with FAT.

> > >   delete mode 100644 include/uapi/linux/netfilter/xt_CONNMARK.h
> > >   delete mode 100644 include/uapi/linux/netfilter/xt_DSCP.h
> > >   delete mode 100644 include/uapi/linux/netfilter/xt_MARK.h
> > >   delete mode 100644 include/uapi/linux/netfilter/xt_RATEEST.h
> > >   delete mode 100644 include/uapi/linux/netfilter/xt_TCPMSS.h
> > >   delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_ECN.h
> > >   delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_TTL.h
> > >   delete mode 100644 include/uapi/linux/netfilter_ipv6/ip6t_HL.h
> > 
> > How did you verify that there is no user space code using these
> > includes?
> > 
> > We take ABI very seriously. You cannot break user space code.
> > 
> >      Andrew
> 
> This is a minimal ABI change, which have to use lower case filenames for
> example: xt_DSCP.h -> xt_dscp.h

You are not listening.

You cannot break user space code.

That is the end of it. No exceptions. It does not matter how bad the
API is. You cannot break it.

    Andrew