netdev - Re: [herbert-cryptodev-2.6:master] [rhashtable] e1d3422c95: stress-ng.syscall.ops_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z3XndzXUa9KYYz9f@gondor.apana.org.au>
Date: Thu, 2 Jan 2025 09:10:15 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Tejun Heo <tj@...nel.org>
Cc: kernel test robot <oliver.sang@...el.com>,
	Breno Leitao <leitao@...ian.org>, oe-lkp@...ts.linux.dev,
	lkp@...el.com, linux-crypto@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [herbert-cryptodev-2.6:master] [rhashtable]  e1d3422c95:
 stress-ng.syscall.ops_per_sec 98.9% regression

On Sun, Dec 29, 2024 at 12:54:47PM -1000, Tejun Heo wrote:
>
> Hmm... the only meaningful behavior difference would be that after the
> patch, rht_grow_above_75() test is done regardless of the return value while
> before it was done only when the return value is zero. Breno, can you please
> look into whether this report is valid and whether restoring the NULL check
> makes it go away?

Actually I fixed that when committing the patch.  It should be
conditional on whether the insertion succeeds or not.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt