netdev - Re: [PATCH v4 4/7] can: Add Nuvoton NCT6694 CAN support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1fdb892b-a1e9-4199-a538-d5b98f283096@wanadoo.fr>
Date: Thu, 2 Jan 2025 18:03:55 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Ming Yu <a0282524688@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
 linux-i2c@...r.kernel.org, linux-can@...r.kernel.org,
 netdev@...r.kernel.org, linux-watchdog@...r.kernel.org,
 linux-hwmon@...r.kernel.org, linux-rtc@...r.kernel.org, tmyu0@...oton.com,
 lee@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl,
 andi.shyti@...nel.org, mkl@...gutronix.de, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, wim@...ux-watchdog.org, linux@...ck-us.net,
 jdelvare@...e.com, alexandre.belloni@...tlin.com
Subject: Re: [PATCH v4 4/7] can: Add Nuvoton NCT6694 CAN support

On 02/01/2025 at 14:40, Ming Yu wrote:
> Dear Vincent,
> 
> Thank you for your comments,
> 
> Vincent Mailhol <mailhol.vincent@...adoo.fr> 於 2024年12月30日 週一 下午1:56寫道：
>>
>>> +config CAN_NCT6694
>>> +     tristate "Nuvoton NCT6694 Socket CANfd support"
>>> +     depends on MFD_NCT6694
>>
>> I think it would be better to do a
>>
>>         select MFD_NCT6694
>>
>> here.
>>
>> Then, make MFD_NCT6694 an hidden configuration in a similar fashion as
>> MFD_CORE. Alone, CONFIG_MFD_NCT6694 does nothing, so better to hide it
>> from the end user.
>>
>> The comment also applies to the other patches.
>>
> 
> I understand, but I noticed that in the Kconfig files of other
> modules, the dependency is written in the form:
> config CAN_NCT6694
>         tristate "Nuvoton NCT6694 Socket CANfd support"
>         depends on MFD_NCT6694
> (e.g. CAN_JANZ_ICAN3, GPIO_DLN2, ...)
> Do you think changing it to select MFD_NCT6694 would be better?

That's a fair point. Looking at the examples you provided, your approach
makes sense. Please ignore my comment here.


Yours sincerely,
Vincent Mailhol