netdev - Re: [PATCH net] net: sfc: Correct key_len for efx_tc_ct_zone_ht

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ad890a7-7035-881e-8613-3ca830e0e7c6@gmail.com>
Date: Thu, 2 Jan 2025 15:36:52 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Liang Jie <buaajxlj@....com>, kuba@...nel.org
Cc: habetsm.xilinx@...il.com, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org,
 pieter.jansen-van-vuuren@....com, netdev@...r.kernel.org,
 linux-net-drivers@....com, linux-kernel@...r.kernel.org,
 Liang Jie <liangjie@...iang.com>
Subject: Re: [PATCH net] net: sfc: Correct key_len for
 efx_tc_ct_zone_ht_params

On 30/12/2024 09:37, Liang Jie wrote:
> From: Liang Jie <liangjie@...iang.com>
> 
> In efx_tc_ct_zone_ht_params, the key_len was previously set to
> offsetof(struct efx_tc_ct_zone, linkage). This calculation is incorrect
> because it includes any padding between the zone field and the linkage
> field due to structure alignment, which can vary between systems.
> 
> This patch updates key_len to use sizeof_field(struct efx_tc_ct_zone, zone)
> , ensuring that the hash table correctly uses the zone as the key. This fix
> prevents potential hash lookup errors and improves connection tracking
> reliability.
> 
> Fixes: c3bb5c6acd4e ("sfc: functions to register for conntrack zone offload")
> Signed-off-by: Liang Jie <liangjie@...iang.com>

Thanks.

Acked-by: Edward Cree <ecree.xilinx@...il.com>