netdev - Re: [PATCH 0/3] selftests: bpf: Migrate test_xdp_redirect.sh to test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3bb87ee-705d-448a-b69c-bdeb650647d5@bootlin.com>
Date: Fri, 3 Jan 2025 11:20:46 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Alexei Starovoitov <ast@...nel.org>,
 Daniel Borkmann <daniel@...earbox.net>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
 Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
 Mykola Lysenko <mykolal@...com>, Shuah Khan <shuah@...nel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Alexis Lothore <alexis.lothore@...tlin.com>, netdev@...r.kernel.org,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] selftests: bpf: Migrate test_xdp_redirect.sh to
 test_progs

Hi all,

On 1/3/25 11:10 AM, Bastien Curutchet (eBPF Foundation) wrote:
> Hi all,
> 
> This patch series continues the work to migrate the *.sh tests into
> prog_tests.
> 
> test_xdp_redirect.sh tests the XDP redirections done through
> bpf_redirect().
> 
> These XDP redirections are already tested by prog_tests/xdp_do_redirect.c
> but IMO it doesn't cover the exact same code path because
> xdp_do_redirect.c uses bpf_prog_test_run_opts() to trigger redirections
> of 'fake packets' while test_xdp_redirect.sh redirects packets coming
> from the network. Also, the test_xdp_redirect.sh script tests the
> redirections with both SKB and DRV modes while xdp_do_redirect.c only
> tests the DRV mode.
> 
> The patch series adds two new test cases in prog_tests/xdp_do_redirect.c
> to replace the test_xdp_redirect.sh script.
> 
> Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@...tlin.com>
> ---

I realize I forgot to mention 'bpf-next', sorry about that.
This work is based on the bpf-next_base branch.

Best regards,
Bastien