netdev - Re: [PATCH net-next 4/4] netconsole: selftest: verify userdata entry limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250103-careful-silent-cuckoo-e4fbba@leitao>
Date: Fri, 3 Jan 2025 03:48:58 -0800
From: Breno Leitao <leitao@...ian.org>
To: Simon Horman <horms@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Shuah Khan <shuah@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next 4/4] netconsole: selftest: verify userdata entry
 limit

Hello Simon,

On Fri, Dec 06, 2024 at 03:09:18PM +0000, Simon Horman wrote:
> On Wed, Dec 04, 2024 at 08:40:45AM -0800, Breno Leitao wrote:
> > Add a new selftest for netconsole that tests the userdata entry limit
> > functionality. The test performs two key verifications:
> > 
> > 1. Create MAX_USERDATA_ITEMS (16) userdata entries successfully
> > 2. Confirm that attempting to create an additional userdata entry fails
> > 
> > The selftest script uses the netcons library and checks the behavior
> > by attempting to create entries beyond the maximum allowed limit.
> > 
> > Signed-off-by: Breno Leitao <leitao@...ian.org>
> > ---
> >  MAINTAINERS                                        |  2 +-
> >  .../selftests/drivers/net/netcons_overflow.sh      | 67 ++++++++++++++++++++++
> >  2 files changed, 68 insertions(+), 1 deletion(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 8af5c9a28e68c4b6a785e2e6b82db20b3cf59822..62192db4641a4056d1eab911f5c141fb37eaed36 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16092,7 +16092,7 @@ S:	Maintained
> >  F:	Documentation/networking/netconsole.rst
> >  F:	drivers/net/netconsole.c
> >  F:	tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh
> > -F:	tools/testing/selftests/drivers/net/netcons_basic.sh
> > +F:	tools/testing/selftests/drivers/net/netcons\*
> >  
> >  NETDEVSIM
> >  M:	Jakub Kicinski <kuba@...nel.org>
> > diff --git a/tools/testing/selftests/drivers/net/netcons_overflow.sh b/tools/testing/selftests/drivers/net/netcons_overflow.sh
> 
> Nit: I think you need to add netcons_overflow.sh to
>      tools/testing/selftests/drivers/net/Makefile

Good catch. I will fix it and send a v2.

Thanks for the review,
--breno