netdev - Re: [PATCH] octeontx2-pf: mcs: Remove dead code and semi-colon from rsrc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5411a125-6a90-405b-9e19-378cfa823ffa@lunn.ch>
Date: Fri, 3 Jan 2025 17:36:40 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Nihar Chaithanya <niharchaithanya@...il.com>
Cc: sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
	hkelam@...vell.com, andrew+netdev@...n.ch, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	sd@...asysnail.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] octeontx2-pf: mcs: Remove dead code and semi-colon from
 rsrc_name()

On Fri, Jan 03, 2025 at 09:28:26PM +0530, Nihar Chaithanya wrote:
> The switch-block has a default branch. Thus, the return statement at the
> end of the function can never be reached.

Deja vue?

I already commented on a similar patch like this. It is not the
default: branch alone which makes the code unreachable. It is that
every case statement makes a return, not a break. This might seem
pedantic, but compiles and static analysers are pedantic, so we
software engineers also need to be pedantic.

Please update the commit message.

Please also take a read of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

    Andrew

---
pw-bot: cr