netdev - Re: [PATCH net] net: don't dump Tx and uninitialized NAPIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLTTC-W-CzcbZAuxNSr1DNnxJfMnSH9Qeo1sdAZOSp=PQ@mail.gmail.com>
Date: Fri, 3 Jan 2025 19:55:44 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	jdamato@...tly.com, almasrymina@...gle.com, sridhar.samudrala@...el.com, 
	amritha.nambiar@...el.com
Subject: Re: [PATCH net] net: don't dump Tx and uninitialized NAPIs

On Fri, Jan 3, 2025 at 7:32 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> We use NAPI ID as the key for continuing dumps. We also depend
> on the NAPIs being sorted by ID within the driver list. Tx NAPIs
> (which don't have an ID assigned) break this expectation, it's
> not currently possible to dump them reliably. Since Tx NAPIs
> are relatively rare, and can't be used in doit (GET or SET)
> hide them from the dump API as well.
>
> Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>