[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202501031530.ss0kvHke-lkp@intel.com>
Date: Fri, 3 Jan 2025 16:12:32 +0800
From: kernel test robot <lkp@...el.com>
To: Samiullah Khawaja <skhawaja@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
skhawaja@...gle.com
Subject: Re: [PATCH net-next 3/3] Extend napi threaded polling to allow
kthread based busy polling
Hi Samiullah,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Samiullah-Khawaja/Add-support-to-set-napi-threaded-for-individual-napi/20250103-031428
base: net-next/main
patch link: https://lore.kernel.org/r/20250102191227.2084046-4-skhawaja%40google.com
patch subject: [PATCH net-next 3/3] Extend napi threaded polling to allow kthread based busy polling
config: x86_64-randconfig-073-20250103 (https://download.01.org/0day-ci/archive/20250103/202501031530.ss0kvHke-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250103/202501031530.ss0kvHke-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501031530.ss0kvHke-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_napi_devs_init':
>> drivers/net/ethernet/mellanox/mlxsw/pci.c:158:50: warning: implicit conversion from 'enum <anonymous>' to 'enum napi_threaded_state' [-Wenum-conversion]
158 | dev_set_threaded(mlxsw_pci->napi_dev_rx, true);
| ^~~~
vim +158 drivers/net/ethernet/mellanox/mlxsw/pci.c
eda6500a987a02 Jiri Pirko 2015-07-29 140
5d01ed2e970812 Amit Cohen 2024-04-26 141 static int mlxsw_pci_napi_devs_init(struct mlxsw_pci *mlxsw_pci)
5d01ed2e970812 Amit Cohen 2024-04-26 142 {
5d01ed2e970812 Amit Cohen 2024-04-26 143 int err;
5d01ed2e970812 Amit Cohen 2024-04-26 144
5d01ed2e970812 Amit Cohen 2024-04-26 145 mlxsw_pci->napi_dev_tx = alloc_netdev_dummy(0);
5d01ed2e970812 Amit Cohen 2024-04-26 146 if (!mlxsw_pci->napi_dev_tx)
5d01ed2e970812 Amit Cohen 2024-04-26 147 return -ENOMEM;
5d01ed2e970812 Amit Cohen 2024-04-26 148 strscpy(mlxsw_pci->napi_dev_tx->name, "mlxsw_tx",
5d01ed2e970812 Amit Cohen 2024-04-26 149 sizeof(mlxsw_pci->napi_dev_tx->name));
5d01ed2e970812 Amit Cohen 2024-04-26 150
5d01ed2e970812 Amit Cohen 2024-04-26 151 mlxsw_pci->napi_dev_rx = alloc_netdev_dummy(0);
5d01ed2e970812 Amit Cohen 2024-04-26 152 if (!mlxsw_pci->napi_dev_rx) {
5d01ed2e970812 Amit Cohen 2024-04-26 153 err = -ENOMEM;
5d01ed2e970812 Amit Cohen 2024-04-26 154 goto err_alloc_rx;
5d01ed2e970812 Amit Cohen 2024-04-26 155 }
5d01ed2e970812 Amit Cohen 2024-04-26 156 strscpy(mlxsw_pci->napi_dev_rx->name, "mlxsw_rx",
5d01ed2e970812 Amit Cohen 2024-04-26 157 sizeof(mlxsw_pci->napi_dev_rx->name));
5d01ed2e970812 Amit Cohen 2024-04-26 @158 dev_set_threaded(mlxsw_pci->napi_dev_rx, true);
5d01ed2e970812 Amit Cohen 2024-04-26 159
5d01ed2e970812 Amit Cohen 2024-04-26 160 return 0;
5d01ed2e970812 Amit Cohen 2024-04-26 161
5d01ed2e970812 Amit Cohen 2024-04-26 162 err_alloc_rx:
5d01ed2e970812 Amit Cohen 2024-04-26 163 free_netdev(mlxsw_pci->napi_dev_tx);
5d01ed2e970812 Amit Cohen 2024-04-26 164 return err;
5d01ed2e970812 Amit Cohen 2024-04-26 165 }
5d01ed2e970812 Amit Cohen 2024-04-26 166
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists