netdev - Re: [PATCH] bridge: Make br_is_nd_neigh_msg() accept pointer to "const struct sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e7a27b5f-a4fc-4eaa-b215-d7a1bb7fc234@blackwall.org>
Date: Fri, 3 Jan 2025 11:59:45 +0200
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Ted Chen <znscnchen@...il.com>, roopa@...dia.com
Cc: bridge@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: Make br_is_nd_neigh_msg() accept pointer to
 "const struct sk_buff"

On 1/3/25 09:09, Ted Chen wrote:
> The skb_buff struct in br_is_nd_neigh_msg() is never modified. Mark it as const.
> 
> Signed-off-by: Ted Chen <znscnchen@...il.com>
> ---
>  net/bridge/br_arp_nd_proxy.c | 2 +-
>  net/bridge/br_private.h      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bridge/br_arp_nd_proxy.c b/net/bridge/br_arp_nd_proxy.c
> index c7869a286df4..115a23054a58 100644
> --- a/net/bridge/br_arp_nd_proxy.c
> +++ b/net/bridge/br_arp_nd_proxy.c
> @@ -229,7 +229,7 @@ void br_do_proxy_suppress_arp(struct sk_buff *skb, struct net_bridge *br,
>  #endif
>  
>  #if IS_ENABLED(CONFIG_IPV6)
> -struct nd_msg *br_is_nd_neigh_msg(struct sk_buff *skb, struct nd_msg *msg)
> +struct nd_msg *br_is_nd_neigh_msg(const struct sk_buff *skb, struct nd_msg *msg)
>  {
>  	struct nd_msg *m;
>  
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 9853cfbb9d14..3fe432babfdf 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -2290,6 +2290,6 @@ void br_do_proxy_suppress_arp(struct sk_buff *skb, struct net_bridge *br,
>  			      u16 vid, struct net_bridge_port *p);
>  void br_do_suppress_nd(struct sk_buff *skb, struct net_bridge *br,
>  		       u16 vid, struct net_bridge_port *p, struct nd_msg *msg);
> -struct nd_msg *br_is_nd_neigh_msg(struct sk_buff *skb, struct nd_msg *m);
> +struct nd_msg *br_is_nd_neigh_msg(const struct sk_buff *skb, struct nd_msg *m);
>  bool br_is_neigh_suppress_enabled(const struct net_bridge_port *p, u16 vid);
>  #endif

Hi,
This should be targeted at net-next (subject should be PATCH net-next).
Also please try to keep commit message lines shorter, checkpatch flags
this one as over 75 characters. You should wait 24 hours before posting
v2 of the patch.

Other than that the patch is ok.

Cheers,
 Nik