netdev - Re: [PATCH] tcp/dccp: allow a connection when sk_max_ack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+cr3+k4_Q9=xtQX3rhL34b+2UvqCCzm+wwAHXrxmgCSA@mail.gmail.com>
Date: Sat, 4 Jan 2025 09:35:13 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: Zhongqiu Duan <dzq.aishenghu0@...il.com>, netdev@...r.kernel.org, davem@...emloft.net, 
	kuba@...nel.org, pabeni@...hat.com, kuniyu@...zon.com
Subject: Re: [PATCH] tcp/dccp: allow a connection when sk_max_ack_backlog is zero

On Sat, Jan 4, 2025 at 2:23 AM Jason Xing <kerneljasonxing@...il.com> wrote:
>
> On Fri, Jan 3, 2025 at 1:14 AM Zhongqiu Duan <dzq.aishenghu0@...il.com> wrote:
> >
> > If the backlog of listen() is set to zero, sk_acceptq_is_full() allows
> > one connection to be made, but inet_csk_reqsk_queue_is_full() does not.
> > When the net.ipv4.tcp_syncookies is zero, inet_csk_reqsk_queue_is_full()
> > will cause an immediate drop before the sk_acceptq_is_full() check in
> > tcp_conn_request(), resulting in no connection can be made.
> >
> > This patch tries to keep consistent with 64a146513f8f ("[NET]: Revert
> > incorrect accept queue backlog changes.").
> >
> > Link: https://lore.kernel.org/netdev/20250102080258.53858-1-kuniyu@amazon.com/
> > Fixes: ef547f2ac16b ("tcp: remove max_qlen_log")
> > Signed-off-by: Zhongqiu Duan <dzq.aishenghu0@...il.com>
>
> Reviewed-by: Jason Xing <kerneljasonxing@...il.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>