netdev - Re: [PATCH net-next v4 18/27] regulator: dt-bindings: Add regulator-power-budget property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mjtwntmupclvy2dvc66zxxob3py47lew47vq37hfi6v6pmbpne@nr62lnuilzya>
Date: Sat, 4 Jan 2025 10:42:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Oleksij Rempel <o.rempel@...gutronix.de>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Jonathan Corbet <corbet@....net>, Donald Hunter <donald.hunter@...il.com>, 
	Rob Herring <robh@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, 
	Simon Horman <horms@...nel.org>, Heiner Kallweit <hkallweit1@...il.com>, 
	Russell King <linux@...linux.org.uk>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org, linux-doc@...r.kernel.org, 
	Kyle Swenson <kyle.swenson@....tech>, Dent Project <dentproject@...uxfoundation.org>, 
	kernel@...gutronix.de, Maxime Chevallier <maxime.chevallier@...tlin.com>, 
	devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v4 18/27] regulator: dt-bindings: Add
 regulator-power-budget property

On Fri, Jan 03, 2025 at 10:13:07PM +0100, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@...tlin.com>
> 
> Introduce a new property to describe the power budget of the regulator.
> This property will allow power management support for regulator consumers
> like PSE controllers, enabling them to make decisions based on the
> available power capacity.
> 
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> ---
> 
> Changes in v3:
> - Add type.
> - Add unit in the name.
> 
> Changes in v2:
> - new patch.
> ---
>  Documentation/devicetree/bindings/regulator/regulator.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/regulator.yaml b/Documentation/devicetree/bindings/regulator/regulator.yaml
> index 1ef380d1515e..c5a6b24ebe7b 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/regulator.yaml
> @@ -34,6 +34,11 @@ properties:
>    regulator-input-current-limit-microamp:
>      description: maximum input current regulator allows
>  
> +  regulator-power-budget-miniwatt:

What sort of quantity prefix is a "mini"? How much is a mini?

> +    description: power budget of the regulator
> +    $ref: /schemas/types.yaml#/definitions/uint32

This should not be needed. Use proper unit from dtschema.

> +
> +

Just one blank line.

Best regards,
Krzysztof