netdev - Re: [PATCH 2/2] net: wwan: iosm: Fix hibernation by re-binding the driver around it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250104084846.300455d4@kernel.org>
Date: Sat, 4 Jan 2025 08:48:46 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc: M Chetan Kumar <m.chetan.kumar@...el.com>, Loic Poulain
 <loic.poulain@...aro.org>, Sergey Ryazanov <ryazanov.s.a@...il.com>,
 Johannes Berg <johannes@...solutions.net>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net: wwan: iosm: Fix hibernation by re-binding the
 driver around it

On Sun, 29 Dec 2024 17:46:59 +0100 Maciej S. Szmigiero wrote:
> +	if (pci_registered)
> +		pci_unregister_driver(&iosm_ipc_driver);
> +
> +	unregister_pm_notifier(&pm_notifier);

The ordering here should be inverted so that you're sure notifier can't
run in parallel.

But I think the notifier is an overkill, there's gotta be an op that
runs. pci_driver::shutdown ? dev_pm_ops::freeze / thaw ?

If you repost please make sure to CC the PCI list, folks there will
know how hibernation is supposed to be handled for sure. Note that
patch 1 is already in Linus's tree so repost just patch 2.