netdev - Re: [PATCH net-next v3] dev: Add NMEA port for MHI WWAN device. (mhi0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8817188-00d0-410b-bfc0-c89fb4784b84@lunn.ch>
Date: Sat, 4 Jan 2025 18:35:06 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Muhammad Nuzaihan <zaihan@...ealasia.net>
Cc: Sergey Ryazanov <ryazanov.s.a@...il.com>,
	Johannes Berg <johannes@...solutions.net>,
	Loic Poulain <loic.poulain@...aro.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] dev: Add NMEA port for MHI WWAN device.
 (mhi0_NMEA)

On Sun, Jan 05, 2025 at 12:38:13AM +0800, Muhammad Nuzaihan wrote:
> Based on the earlier v2 and v1 patches. This patch is a cleanup from v2.
> 
> Removed unnecessary code added to "iosm" and "AT IOCTL" which is not
> relevant.
> 
> Tested this change on a new kernel and module built and now device NMEA
> (mhi0_NMEA) statements are available through /dev/wwan0nmea0 port on bootup.
> 
> Signed-off-by: Muhammad Nuzaihan Bin Kamal Luddin <zaihan@...ealasia.net>
> ---
> v3:
> - Rebased to net-next main branch
> - Removed earlier patches that added unnecessary iosm (unrelated) and AT
> IOCTL code.
> v2: https://lore.kernel.org/netdev/5LHFPS.G3DNPFBCDKCL2@unrealasia.net/
> v1: https://lore.kernel.org/netdev/R8AFPS.THYVK2DKSEE83@unrealasia.net/
> ---
> 
> drivers/net/wwan/mhi_wwan_ctrl.c | 1 +
> drivers/net/wwan/wwan_core.c | 4 ++++
> include/linux/wwan.h | 2 ++
> 3 files changed, 7 insertions(+)
> 
> diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c
> b/drivers/net/wwan/mhi_wwan_ctrl.c
> index e9f979d2d851..e13c0b078175 100644
> --- a/drivers/net/wwan/mhi_wwan_ctrl.c
> +++ b/drivers/net/wwan/mhi_wwan_ctrl.c
> @@ -263,6 +263,7 @@ static const struct mhi_device_id
> mhi_wwan_ctrl_match_table[] = {
>        { .chan = "QMI", .driver_data = WWAN_PORT_QMI },
>        { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM },
>        { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE },
> +	{ .chan = "NMEA", .driver_data = WWAN_PORT_NMEA },

The indentation is all messed up in this patch. It looks like a tab to
space conversion has happened somewhere?

Did you use git send-email?

    Andrew

---
pw-bot: cr