netdev - Re: [PATCH net-next] eth: fbnic: update fbnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH-L+nO5WbTyc+y8c-fmumn5bc5ucpanLeX5Q5RtLfrf3AaN5Q@mail.gmail.com>
Date: Sun, 5 Jan 2025 12:09:45 +0530
From: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org, 
	andrew@...n.ch, andrew+netdev@...n.ch, davem@...emloft.net, 
	edumazet@...gle.com, pabeni@...hat.com, vadim.fedorenko@...ux.dev, 
	damato@...tly.com, brett.creeley@....com, kernel-team@...a.com
Subject: Re: [PATCH net-next] eth: fbnic: update fbnic_poll return value

On Sat, Jan 4, 2025 at 7:23 AM Mohsin Bashir <mohsin.bashr@...il.com> wrote:
>
> In cases where the work done is less than the budget, `fbnic_poll` is
> returning 0. This affects the tracing of `napi_poll`. Following is a
> snippet of before and after result from `napi_poll` tracepoint. Instead,
> returning the work done improves the manual tracing.
>
> Before:
> @[10]: 1
> ...
> @[64]: 208175
> @[0]: 2128008
>
> After:
> @[56]: 86
> @[48]: 222
> ...
> @[5]: 1885756
> @[6]: 1933841
>
> Signed-off-by: Mohsin Bashir <mohsin.bashr@...il.com>
LGTM,
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>

-- 
Regards,
Kalesh AP

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4239 bytes)