netdev - Re: Re: [PATCH v4 -next 13/15] x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ka6zci6bvgvyvlxf5u5g7ecefpqlrlqxwzdviukonmvtzeed54@fkseedf6ilms>
Date: Mon, 6 Jan 2025 13:14:06 +0100
From: Joel Granados <joel.granados@...nel.org>
To: yukaixiong <yukaixiong@...wei.com>
Cc: Brian Gerst <brgerst@...il.com>, akpm@...ux-foundation.org, 
	mcgrof@...nel.org, ysato@...rs.sourceforge.jp, dalias@...c.org, 
	glaubitz@...sik.fu-berlin.de, luto@...nel.org, tglx@...utronix.de, mingo@...hat.com, 
	bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com, 
	viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz, kees@...nel.org, 
	j.granados@...sung.com, willy@...radead.org, Liam.Howlett@...cle.com, vbabka@...e.cz, 
	lorenzo.stoakes@...cle.com, trondmy@...nel.org, anna@...nel.org, chuck.lever@...cle.com, 
	jlayton@...nel.org, neilb@...e.de, okorniev@...hat.com, Dai.Ngo@...cle.com, 
	tom@...pey.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, paul@...l-moore.com, jmorris@...ei.org, linux-sh@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, 
	linux-nfs@...r.kernel.org, netdev@...r.kernel.org, linux-security-module@...r.kernel.org, 
	dhowells@...hat.com, haifeng.xu@...pee.com, baolin.wang@...ux.alibaba.com, 
	shikemeng@...weicloud.com, dchinner@...hat.com, bfoster@...hat.com, souravpanda@...gle.com, 
	hannes@...xchg.org, rientjes@...gle.com, pasha.tatashin@...een.com, david@...hat.com, 
	ryan.roberts@....com, ying.huang@...el.com, yang@...amperecomputing.com, 
	zev@...ilderbeest.net, serge@...lyn.com, vegard.nossum@...cle.com, 
	wangkefeng.wang@...wei.com
Subject: Re: Re: [PATCH v4 -next 13/15] x86: vdso: move the sysctl to
 arch/x86/entry/vdso/vdso32-setup.c

On Mon, Dec 30, 2024 at 02:43:12PM +0800, yukaixiong wrote:
> 
> 
> On 2024/12/30 7:05, Brian Gerst wrote:
> > On Sat, Dec 28, 2024 at 10:17 AM Kaixiong Yu <yukaixiong@...wei.com> wrote:
...
> >>          return 0;
> >>   }
> >>   __initcall(ia32_binfmt_init);
> >>   #endif /* CONFIG_SYSCTL */
> >>
> >> -#endif /* CONFIG_X86_64 */
> >
> > Brian Gerst
> > .
> Hello all；
> 
> I want to confirm that I should send a new patch series, such as "PATCH 
> v5 -next"， or just modify this patch by
> "git send-email -in-reply-to xxxxx"，or the maintainer will fix this issue ?
There are still some outstanding comments (besides this one) to the
series that you must address. This is what I propose:

1. Address the outstanding feedback in the series
2. Wait a couple of more days to see if you get more feedback
3. For your next versions, please include the tags from previous
   reviews; I see that you have not added Lorenzo's reviewed by for
   "[PATCH v4 -next 06/15] mm: mmap: move sysctl to mm/mmap.c" and
   "[PATCH v4 -next 08/15] mm: nommu: move sysctl to mm/nommu.c"
4. Once you have addresses all the issues, Send a V5. If there are still
   issues with this version, then we can cherry-pick the patches that
   are already reviewed into upstream and continue working on the ones
   with issues.

Best

-- 

Joel Granados