netdev - Re: [PATCH net-next] net: watchdog: rename __dev_watchdog_up() and dev_watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoBdus0aH2GagbAkfxpsUh0q7YOHy0GguXeoABVYrQ_t=w@mail.gmail.com>
Date: Mon, 6 Jan 2025 10:38:10 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, Simon Horman <horms@...nel.org>, 
	eric.dumazet@...il.com, Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net-next] net: watchdog: rename __dev_watchdog_up() and dev_watchdog_down()

On Sun, Jan 5, 2025 at 5:09 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> In commit d7811e623dd4 ("[NET]: Drop tx lock in dev_watchdog_up")
> dev_watchdog_up() became a simple wrapper for __netdev_watchdog_up()
>
> Herbert also said : "In 2.6.19 we can eliminate the unnecessary
> __dev_watchdog_up and replace it with dev_watchdog_up."
>
> This patch consolidates things to have only two functions, with
> a common prefix.
>
> - netdev_watchdog_up(), exported for the sake of one freescale driver.
>   This replaces __netdev_watchdog_up() and dev_watchdog_up().
>
> - netdev_watchdog_down(), static to net/sched/sch_generic.c
>   This replaces dev_watchdog_down().
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>

Reviewed-by: Jason Xing <kerneljasonxing@...il.com>