netdev - Re: [PATCH net-next 2/9] net: dsa: mt753x: remove setting of tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd07fea7-2473-458a-b0f2-f03afb6a8b32@arinc9.com>
Date: Mon, 06 Jan 2025 13:01:59 +0000 (UTC)
From: "Chester A. Unal" <chester.a.unal@...nc9.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
 Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Ar__n__ __NAL <arinc.unal@...nc9.com>, Daniel Golle <daniel@...rotopia.org>,
 "David S. Miller" <davem@...emloft.net>, DENG Qingfang <dqfext@...il.com>,
 Eric Dumazet <edumazet@...gle.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Jakub Kicinski <kuba@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, Matthias Brugger
 <matthias.bgg@...il.com>, netdev@...r.kernel.org,
 Paolo Abeni <pabeni@...hat.com>, Sean Wang <sean.wang@...iatek.com>,
 Simon Horman <horms@...nel.org>, UNGLinuxDriver@...rochip.com,
 Vladimir Oltean <olteanv@...il.com>, Woojung Huh <woojung.huh@...rochip.com>
Subject: Re: [PATCH net-next 2/9] net: dsa: mt753x: remove setting of tx_lpi
 parameters

On 06/01/2025 11:58, Russell King (Oracle) wrote:
> dsa_user_get_eee() calls the DSA switch get_mac_eee() method followed
> by phylink_ethtool_get_eee(), which goes on to call
> phy_ethtool_get_eee(). This overwrites all members of the passed
> ethtool_keee, which means anything written by the DSA switch
> get_mac_eee() method will be discarded.
> 
> Remove setting any members in mt753x_get_mac_eee().
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Chester A. Unal <chester.a.unal@...nc9.com>

Chester A.