netdev - Re: [PATCH v2 2/3] usb/cx231xx: Remove unused value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b228c210-73a9-4d4a-b884-7230be59dd82@xs4all.nl>
Date: Mon, 6 Jan 2025 15:07:44 +0100
From: Hans Verkuil <hverkuil@...all.nl>
To: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>,
 linux-media@...r.kernel.org, linux-mips@...r.kernel.org,
 netdev@...r.kernel.org, linux-can@...r.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v2 2/3] usb/cx231xx: Remove unused value

On 21/12/2024 12:06, Ariel Otilibili wrote:
> Coverity-ID: 1269153
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@...ecom.fr>
> ---
>  drivers/media/usb/cx231xx/cx231xx-avcore.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/usb/cx231xx/cx231xx-avcore.c b/drivers/media/usb/cx231xx/cx231xx-avcore.c
> index 1cfec76b72f3..f2a2d0c39080 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-avcore.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-avcore.c
> @@ -1896,7 +1896,6 @@ int cx231xx_dif_set_standard(struct cx231xx *dev, u32 standard)
>  		status = vid_blk_write_word(dev, DIF_SOFT_RST_CTRL_REVB,
>  						0x00000000);
>  		/* Save the Spec Inversion value */
> -		dif_misc_ctrl_value &= FLD_DIF_SPEC_INV;

Don't remove this line,

>  		dif_misc_ctrl_value = 0x3A093F10;

instead this should have been |=, just like is done elsewhere in this function.

>  	} else if (standard &
>  		  (V4L2_STD_SECAM_B | V4L2_STD_SECAM_D | V4L2_STD_SECAM_G |

Also, please just post this as a separate patch to linux-media. It is bad form
to mix subsystems in the same patch series if there is no reason for it.

Regards,

	Hans