netdev - Re: [PATCH v11 0/1] MCTP Over PCC Transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b5fa6fa9-8e59-404a-9604-18568d3c5ed8@amperemail.onmicrosoft.com>
Date: Mon, 6 Jan 2025 12:30:20 -0500
From: Adam Young <admiyo@...eremail.onmicrosoft.com>
To: Jeremy Kerr <jk@...econstruct.com.au>, admiyo@...amperecomputing.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 Matt Johnston <matt@...econstruct.com.au>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Sudeep Holla <sudeep.holla@....com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Huisong Li <lihuisong@...wei.com>
Subject: Re: [PATCH v11 0/1] MCTP Over PCC Transport

I had a side channel discussion with the spec writer and that is in 
keeping with what he says as well.  V12 to be posted shortly.

Should I move more of the cover letter information in to the commit message?

On 1/5/25 20:05, Jeremy Kerr wrote:
> Hi Adam,
>> Changes in V11:
>> - Switch Big Endian data types to machine local for PCC header
> This seems suspicious; the concept of "machine local" may not be
> consistent between channel endpoints (ie, system firmware and this
> driver). Looking at DSP0292, and the PCC channel spec, it looks like
> these should be explicitly little-endian, no?
>
> The warnings you were seeing in v10 seemed to be an issue of direct
> accesses to the __be32 types in struct mctp_pcc_hdr - ie., without
> be32_to_cpu() accessors. If you keep the endian-annotated types (but
> __le32 instead), and use the appropriate le32_to_cpu() accessors, that
> should address those warnings, while keeping the driver endian-safe.
>
> Cheers,
>
>
> Jeremy
>