netdev - RE: [PATCH net-next 1/4] net: wangxun: Add support for PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089A049124A5DEED5F15A4AD6102@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Mon, 6 Jan 2025 21:29:44 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Jiawen Wu <jiawenwu@...stnetic.com>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"richardcochran@...il.com" <richardcochran@...il.com>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>, "horms@...nel.org"
	<horms@...nel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next 1/4] net: wangxun: Add support for PTP clock



> -----Original Message-----
> From: Jiawen Wu <jiawenwu@...stnetic.com>
> Sent: Thursday, January 2, 2025 2:30 AM
> To: andrew+netdev@...n.ch; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; richardcochran@...il.com;
> linux@...linux.org.uk; horms@...nel.org; Keller, Jacob E
> <jacob.e.keller@...el.com>; netdev@...r.kernel.org
> Cc: mengyuanlou@...-swift.com; Jiawen Wu <jiawenwu@...stnetic.com>
> Subject: [PATCH net-next 1/4] net: wangxun: Add support for PTP clock
> 
> Implement support for PTP clock on Wangxun NICs.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>
> ---
>  drivers/net/ethernet/wangxun/libwx/Makefile   |   2 +-
>  .../net/ethernet/wangxun/libwx/wx_ethtool.c   |   3 +
>  drivers/net/ethernet/wangxun/libwx/wx_lib.c   |  64 +-
>  drivers/net/ethernet/wangxun/libwx/wx_lib.h   |   1 +
>  drivers/net/ethernet/wangxun/libwx/wx_ptp.c   | 719 ++++++++++++++++++
>  drivers/net/ethernet/wangxun/libwx/wx_ptp.h   |  16 +
>  drivers/net/ethernet/wangxun/libwx/wx_type.h  |  67 ++
>  drivers/net/ethernet/wangxun/ngbe/ngbe_main.c |   7 +
>  drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c |  10 +
>  .../net/ethernet/wangxun/txgbe/txgbe_main.c   |  10 +
>  .../net/ethernet/wangxun/txgbe/txgbe_phy.c    |   9 +
>  11 files changed, 902 insertions(+), 6 deletions(-)
>  create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_ptp.c
>  create mode 100644 drivers/net/ethernet/wangxun/libwx/wx_ptp.h
> 
> diff --git a/drivers/net/ethernet/wangxun/libwx/Makefile
> b/drivers/net/ethernet/wangxun/libwx/Makefile
> index 42ccd6e4052e..e9f0f1f2309b 100644
> --- a/drivers/net/ethernet/wangxun/libwx/Makefile
> +++ b/drivers/net/ethernet/wangxun/libwx/Makefile
> @@ -4,4 +4,4 @@
> 
>  obj-$(CONFIG_LIBWX) += libwx.o
> 
> -libwx-objs := wx_hw.o wx_lib.o wx_ethtool.o
> +libwx-objs := wx_hw.o wx_lib.o wx_ethtool.o wx_ptp.o
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> b/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> index abe5921dde02..c4b3b00b0926 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_ethtool.c
> @@ -41,6 +41,9 @@ static const struct wx_stats wx_gstrings_stats[] = {
>  	WX_STAT("rx_csum_offload_good_count", hw_csum_rx_good),
>  	WX_STAT("rx_csum_offload_errors", hw_csum_rx_error),
>  	WX_STAT("alloc_rx_buff_failed", alloc_rx_buff_failed),
> +	WX_STAT("tx_hwtstamp_timeouts", tx_hwtstamp_timeouts),
> +	WX_STAT("tx_hwtstamp_skipped", tx_hwtstamp_skipped),
> +	WX_STAT("rx_hwtstamp_cleared", rx_hwtstamp_cleared),
>  };

I know this is a little old, but didn't we recently introduce a generic ethtool interface for PTP statistics? Could you please make sure that interface is implemented? I think the current policy is that the more specific errors can still be here, but we should implement the basic standardization available.

Thanks,
Jake