netdev - Re: [PATCH v2] eth: fbnic: Avoid garbage value in fbnic_mac_get_sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <793c3449-ba5c-9aef-90e4-1515e85cd822@nfschina.com>
Date: Mon, 6 Jan 2025 09:08:58 +0800
From: Su Hui <suhui@...china.com>
To: Jakub Kicinski <kuba@...nel.org>,
 Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
 Su Hui <suhui@...china.com>
Cc: alexanderduyck@...com, kernel-team@...a.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, mohsin.bashr@...il.com, sanmanpradhan@...a.com,
 kalesh-anakkur.purayil@...adcom.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] eth: fbnic: Avoid garbage value in
 fbnic_mac_get_sensor_asic()

On 2025/1/4 02:07, Jakub Kicinski wrote:
> On Mon, 30 Dec 2024 08:52:49 -0800 Jakub Kicinski wrote:
>>> It is more like removing broken functionality than fixing (maybe whole
>>> commit should be reverted). Anyway returning not support is also fine.
>> I defer to other maintainers. The gaps are trivial to fill in, we'll
>> do so as soon as this patch makes it to net-next (this patch needs to
>> target net).
> Having slept on it, I think you're right.
>
> Su Hui, could you send a revert of d85ebade02e8 instead?
> It's around 126 LoC, not too bad.

OK, I will send v3 to revert d85ebade02e8 soon.

Su Hui