netdev - Re: [PATCH net-next 4/8] netdevsim: allocate rqs individually

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLafXzZcdfTzGFgqdxumDweS28AZ-KoPgjcx=ZpsvNABg@mail.gmail.com>
Date: Mon, 6 Jan 2025 10:52:24 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	dw@...idwei.uk, almasrymina@...gle.com, jdamato@...tly.com
Subject: Re: [PATCH net-next 4/8] netdevsim: allocate rqs individually

On Fri, Jan 3, 2025 at 8:00 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> Make nsim->rqs an array of pointers and allocate them individually
> so that we can swap them out one by one.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/netdevsim/netdev.c    | 43 ++++++++++++++++++++-----------
>  drivers/net/netdevsim/netdevsim.h |  2 +-
>  2 files changed, 29 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c
> index a4aacd372cdd..7487697ac417 100644
> --- a/drivers/net/netdevsim/netdev.c
> +++ b/drivers/net/netdevsim/netdev.c
> @@ -69,7 +69,7 @@ static netdev_tx_t nsim_start_xmit(struct sk_buff *skb, struct net_device *dev)
>         rxq = skb_get_queue_mapping(skb);
>         if (rxq >= peer_dev->num_rx_queues)
>                 rxq = rxq % peer_dev->num_rx_queues;

Orthogonal to your patch, but I wonder why we do not use
dev->real_num_rx_queues here.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>