netdev - Re: [PATCH net] eth: gve: use appropriate helper to set xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <677cf42b9e361_23f4742946a@willemb.c.googlers.com.notmuch>
Date: Tue, 07 Jan 2025 04:30:19 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jeroen de Borst <jeroendb@...gle.com>, 
 Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, 
 netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 pkaligineedi@...gle.com, 
 shailend@...gle.com, 
 hawk@...nel.org, 
 john.fastabend@...il.com, 
 willemb@...gle.com, 
 bpf@...r.kernel.org
Subject: Re: [PATCH net] eth: gve: use appropriate helper to set xdp_features

Jeroen de Borst wrote:
> Reviewed-By: Jeroen de Borst <jeroendb@...gle.com>
> 
> 
> 
> On Mon, Jan 6, 2025 at 10:02 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > Commit f85949f98206 ("xdp: add xdp_set_features_flag utility routine")
> > added routines to inform the core about XDP flag changes.
> > GVE support was added around the same time and missed using them.
> >
> > GVE only changes the flags on error recover or resume.
> > Presumably the flags may change during resume if VM migrated.
> > User would not get the notification and upper devices would
> > not get a chance to recalculate their flags.
> >
> > Fixes: 75eaae158b1b ("gve: Add XDP DROP and TX support for GQI-QPL format")
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Thanks!

> > ---
> > CC: jeroendb@...gle.com

Reminder: please don't top post