netdev - RE: [Intel-wired-lan] [PATCH iwl-net 2/4] igb: introduce raw vfs_lock to igb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58652A9179F79F7A7BCCA9C88F112@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Tue, 7 Jan 2025 10:08:25 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Wander Lairson Costa <wander@...hat.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Sebastian
 Andrzej Siewior" <bigeasy@...utronix.de>, Clark Williams
	<clrkwllms@...nel.org>, Steven Rostedt <rostedt@...dmis.org>, Jeff Garzik
	<jgarzik@...hat.com>, Auke Kok <auke-jan.h.kok@...el.com>, "moderated
 list:INTEL ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org>, "open
 list:NETWORKING DRIVERS" <netdev@...r.kernel.org>, open list
	<linux-kernel@...r.kernel.org>, "open list:Real-time Linux
 (PREEMPT_RT):Keyword:PREEMPT_RT" <linux-rt-devel@...ts.linux.dev>
CC: Clark Williams <williams@...hat.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 2/4] igb: introduce raw vfs_lock
 to igb_adapter

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Wander Lairson Costa
> Sent: Wednesday, December 4, 2024 12:42 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; Andrew Lunn <andrew+netdev@...n.ch>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Sebastian Andrzej Siewior <bigeasy@...utronix.de>; Clark
> Williams <clrkwllms@...nel.org>; Steven Rostedt <rostedt@...dmis.org>; Jeff
> Garzik <jgarzik@...hat.com>; Auke Kok <auke-jan.h.kok@...el.com>; moderated
> list:INTEL ETHERNET DRIVERS <intel-wired-lan@...ts.osuosl.org>; open
> list:NETWORKING DRIVERS <netdev@...r.kernel.org>; open list <linux-
> kernel@...r.kernel.org>; open list:Real-time Linux
> (PREEMPT_RT):Keyword:PREEMPT_RT <linux-rt-devel@...ts.linux.dev>
> Cc: Wander Lairson Costa <wander@...hat.com>; Clark Williams
> <williams@...hat.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net 2/4] igb: introduce raw vfs_lock to
> igb_adapter
> 
> This change adds a raw_spinlock for the vfs_lock to the igb_adapter structure,
> enabling its use in both interrupt and preemptible contexts. This is essential for
> upcoming modifications to split igb_msg_task() into interrupt-safe and
> preemptible-safe parts.
> 
> The motivation for this change stems from the need to modify
> igb_msix_other() to run in interrupt context under PREEMPT_RT.
> Currently, igb_msg_task() contains a code path that invokes
> kcalloc() with the GFP_ATOMIC flag. However, on PREEMPT_RT, GFP_ATOMIC is
> not honored, making it unsafe to call allocation functions in interrupt context. By
> introducing this raw spinlock, we can safely acquire the lock in both contexts,
> paving the way for the necessary restructuring of igb_msg_task().
> 
> Signed-off-by: Wander Lairson Costa <wander@...hat.com>
> Suggested-by: Clark Williams <williams@...hat.com>
> ---
>  drivers/net/ethernet/intel/igb/igb.h      |  4 ++
>  drivers/net/ethernet/intel/igb/igb_main.c | 51 ++++++++++++++++++++---
>  2 files changed, 50 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb.h
> b/drivers/net/ethernet/intel/igb/igb.h
> index 3c2dc7bdebb50..d50c22f09d0f8 100644
> --- a/drivers/net/ethernet/intel/igb/igb.h
> +++ b/drivers/net/ethernet/intel/igb/igb.h
> @@ -666,6 +666,10 @@ struct igb_adapter {


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>