netdev - Re: [PATCH ipsec-next 1/2] xfrm: Support ESN context update to hardware for TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z30WcStdG5Z4tDru@gauss3.secunet.de>
Date: Tue, 7 Jan 2025 12:56:33 +0100
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Leon Romanovsky <leon@...nel.org>
CC: Jianbo Liu <jianbol@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"Eric Dumazet" <edumazet@...gle.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, Jakub Kicinski <kuba@...nel.org>, Jonathan
 Corbet <corbet@....net>, <linux-doc@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <netdev@...r.kernel.org>, Paolo Abeni
	<pabeni@...hat.com>, "Potnuri Bharat Teja" <bharat@...lsio.com>, Saeed
 Mahameed <saeedm@...dia.com>, Tariq Toukan <tariqt@...dia.com>
Subject: Re: [PATCH ipsec-next 1/2] xfrm: Support ESN context update to
 hardware for TX

On Tue, Jan 07, 2025 at 12:22:04PM +0200, Leon Romanovsky wrote:
> On Thu, Dec 19, 2024 at 02:37:29PM +0200, Leon Romanovsky wrote:
> > From: Jianbo Liu <jianbol@...dia.com>
> > 
> > Previously xfrm_dev_state_advance_esn() was added for RX only. But
> > it's possible that ESN context also need to be synced to hardware for
> > TX, so call it for outbound in this patch.
> > 
> > Signed-off-by: Jianbo Liu <jianbol@...dia.com>
> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> > ---
> >  Documentation/networking/xfrm_device.rst                 | 3 ++-
> >  drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c          | 3 +++
> >  drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec.c | 3 +++
> >  net/xfrm/xfrm_replay.c                                   | 1 +
> >  4 files changed, 9 insertions(+), 1 deletion(-)
> 
> Steffen,
> 
> This is kindly reminder.

Sorry for the dealy, the holidays came faster than expected :)

> > diff --git a/net/xfrm/xfrm_replay.c b/net/xfrm/xfrm_replay.c
> > index bc56c6305725..e500aebbad22 100644
> > --- a/net/xfrm/xfrm_replay.c
> > +++ b/net/xfrm/xfrm_replay.c
> > @@ -729,6 +729,7 @@ static int xfrm_replay_overflow_offload_esn(struct xfrm_state *x, struct sk_buff
> >  		}
> >  
> >  		replay_esn->oseq = oseq;
> > +		xfrm_dev_state_advance_esn(x);

This is the only line of code that this patchset adds
to the xfrm stack, so merging this through mlx5 might
create less conflicts.

In case you want to do that, you can add my 'Acked-by'
to this patch. Otherwise I'll pull it into the ipsec-next
tree tomorrow.