lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3ab1a86f-5c37-4421-b4df-5d73729f1381@gmail.com>
Date: Tue, 7 Jan 2025 08:18:05 -0500
From: Daniel Zahka <daniel.zahka@...il.com>
To: Danielle Ratson <danieller@...dia.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Jakub Kicinski <kuba@...nel.org>, Ido Schimmel <idosch@...dia.com>,
 "mkubecek@...e.cz" <mkubecek@...e.cz>
Subject: Re: [RFC ethtool] ethtool: mock JSON output for --module-info

The json output looks good on my cards with CMIS modules. On a different 
card that does not support the CMIS interface, the output falls back to 
non-json, even when --json is specified. Maybe this should return an 
error. Other than that, looks good to me. Thanks.

On 1/2/25 3:19 AM, Danielle Ratson wrote:
> Hi,
>
> Any comments?
>
>> -----Original Message-----
>> From: Daniel Zahka <daniel.zahka@...il.com>
>> Sent: Thursday, 19 December 2024 19:35
>> To: Danielle Ratson <danieller@...dia.com>
>> Cc: netdev@...r.kernel.org; Jakub Kicinski <kuba@...nel.org>; Ido Schimmel
>> <idosch@...dia.com>; mkubecek@...e.cz
>> Subject: Re: [RFC ethtool] ethtool: mock JSON output for --module-info
>>
>>
>> On 12/19/24 9:18 AM, Danielle Ratson wrote:
>>> Hi Daniel,
>>>
>>> I didn’t get a reply from you.
>>> Anyway, here's a like to my git repository:
>> https://github.com/daniellerts/ethtool/tree/eeprom_json_rfc.
>>> The last 4 commits are the relevant ones.
>>>
>>> All the CMIS modules dump fields are implemented were sent to internal
>> review.
>>> Thanks,
>>> Danielle
>>
>> Thank you! I'll try it out on my machines.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ