netdev - Re: [PATCH net] net: phy: fix phylib's dual eee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250107144048.1c747bf1@bootlin.com>
Date: Tue, 7 Jan 2025 14:40:48 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Oleksij Rempel <o.rempel@...gutronix.de>,
 netdev@...r.kernel.org, Luca Ceresoli <luca.ceresoli@...tlin.com>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH net] net: phy: fix phylib's dual eee_enabled

Hi,

On Thu, 14 Nov 2024 10:33:27 +0000
"Russell King (Oracle)" <rmk+kernel@...linux.org.uk> wrote:

> phylib has two eee_enabled members. Some parts of the code are using
> phydev->eee_enabled, other parts are using phydev->eee_cfg.eee_enabled.
> This leads to incorrect behaviour as their state goes out of sync.
> ethtool --show-eee shows incorrect information, and --set-eee sometimes
> doesn't take effect.
> 
> Fix this by only having one eee_enabled member - that in eee_cfg.
> 
> Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/phy/phy-c45.c    | 4 +---
>  drivers/net/phy/phy_device.c | 4 ++--
>  include/linux/phy.h          | 2 --
>  3 files changed, 3 insertions(+), 7 deletions(-)
> 

I observed a regression with this patch applied.

My system is based on a i.MX8MP soc with a TI DP83867 ethernet PHY and was
working with the kernel v6.12 release.

Using the v6.13-rc6 kernel leads to a low ethernet bandwidth.

I used to perform SCP transfers at around 6MB/s on my setup and after moving
to the last v6.13-rc6 kernel, the bandwidth dropped to 70KB/s.

A git bisect identified the commit 41ffcd95015f ("net: phy: fix phylib's dual
eee_enabled").

With this patch applied, the issue is present. Without the patch, the issue
is not present. Also if I add the 'eee-broken-100tx' device-tree property in
the PHY node, the issue is not present anymore.

Didn't investigated more the issue but the patch introduced a regression on
my system.

Best regards,
Hervé