[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <034e01db60a6$8f984400$aec8cc00$@trustnetic.com>
Date: Tue, 7 Jan 2025 09:50:42 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Richard Cochran'" <richardcochran@...il.com>
Cc: <andrew+netdev@...n.ch>,
<davem@...emloft.net>,
<edumazet@...gle.com>,
<kuba@...nel.org>,
<pabeni@...hat.com>,
<linux@...linux.org.uk>,
<horms@...nel.org>,
<jacob.e.keller@...el.com>,
<netdev@...r.kernel.org>,
<vadim.fedorenko@...ux.dev>,
<mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next v2 3/4] net: wangxun: Implement do_aux_work of ptp_clock_info
On Mon, Jan 6, 2025 11:16 PM, Richard Cochran wrote:
> On Mon, Jan 06, 2025 at 04:45:05PM +0800, Jiawen Wu wrote:
>
> > +static int wx_ptp_feature_enable(struct ptp_clock_info *ptp,
> > + struct ptp_clock_request *rq, int on)
> > +{
> > + struct wx *wx = container_of(ptp, struct wx, ptp_caps);
> > +
> > + /**
> > + * When PPS is enabled, unmask the interrupt for the ClockOut
> > + * feature, so that the interrupt handler can send the PPS
> > + * event when the clock SDP triggers. Clear mask when PPS is
> > + * disabled
> > + */
> > + if (rq->type != PTP_CLK_REQ_PPS || !wx->ptp_setup_sdp)
> > + return -EOPNOTSUPP;
>
> NAK.
>
> The logic that you added in patch #4 is a periodic output signal, so
> your driver will support PTP_CLK_REQ_PEROUT and not PTP_CLK_REQ_PPS.
>
> Please change the driver to use that instead.
Oh sorry, I messed up the patches. These belong to patch 4/4.
Powered by blists - more mailing lists