[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <677d34ea7523_25382b29484@willemb.c.googlers.com.notmuch>
Date: Tue, 07 Jan 2025 09:06:34 -0500
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>,
davem@...emloft.net
Cc: netdev@...r.kernel.org,
edumazet@...gle.com,
pabeni@...hat.com,
dw@...idwei.uk,
almasrymina@...gle.com,
jdamato@...tly.com,
Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 0/8] net: make sure we retain NAPI ordering on
netdev->napi_list
Jakub Kicinski wrote:
> I promised Eric to remove the rtnl protection of the NAPI list,
> when I sat down to implement it over the break I realized that
> the recently added NAPI ID retention will break the list ordering
> assumption we have in netlink dump. The ordering used to happen
> "naturally", because we'd always add NAPIs that the head of the
> list, and assign a new monotonically increasing ID.
>
> Before the first patch of this series we'd still only add at
> the head of the list but now the newly added NAPI may inherit
> from its config an ID lower than something else already on the list.
>
> The fix is in the first patch, the rest is netdevsim churn to test it.
> I'm posting this for net-next, because AFAICT the problem can't
> be triggered in net, given the very limited queue API adoption.
For the series, subject to the indentation issue raised earlier:
Reviewed-by: Willem de Bruijn <willemb@...gle.com>
Powered by blists - more mailing lists