netdev - Re: [PATCH net] net: phy: fix phylib's dual eee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250107152345.6bbb9853@bootlin.com>
Date: Tue, 7 Jan 2025 15:23:45 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 Luca Ceresoli <luca.ceresoli@...tlin.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH net] net: phy: fix phylib's dual eee_enabled

On Tue, 7 Jan 2025 15:13:52 +0100
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> On Tue, Jan 07, 2025 at 02:40:48PM +0100, Herve Codina wrote:
> > Hi,
> > 
> > On Thu, 14 Nov 2024 10:33:27 +0000
> > "Russell King (Oracle)" <rmk+kernel@...linux.org.uk> wrote:
> >   
> > > phylib has two eee_enabled members. Some parts of the code are using
> > > phydev->eee_enabled, other parts are using phydev->eee_cfg.eee_enabled.
> > > This leads to incorrect behaviour as their state goes out of sync.
> > > ethtool --show-eee shows incorrect information, and --set-eee sometimes
> > > doesn't take effect.
> > > 
> > > Fix this by only having one eee_enabled member - that in eee_cfg.
> > > 
> > > Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE")
> > > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> > > ---
> > >  drivers/net/phy/phy-c45.c    | 4 +---
> > >  drivers/net/phy/phy_device.c | 4 ++--
> > >  include/linux/phy.h          | 2 --
> > >  3 files changed, 3 insertions(+), 7 deletions(-)
> > >   
> > 
> > I observed a regression with this patch applied.
> > 
> > My system is based on a i.MX8MP soc with a TI DP83867 ethernet PHY and was
> > working with the kernel v6.12 release.  
> 
> Which ethernet interface is used on this system? FEC or stmmac?

It is the FEC (ethernet@...e0000).

> 
> Is it the correct PHY?
> https://www.ti.com/product/de-de/DP83867E

Yes, it is this PHY.

Best regards,
Hervé