netdev - Re: [PATCH net-next v7 10/10] selftest: net-drv: hds: add test for HDS feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMArcTUzQiJfeH4+EUgUYrJdgUor5qv1wKN9sLd7CtwrNV2Utg@mail.gmail.com>
Date: Tue, 7 Jan 2025 23:56:03 +0900
From: Taehee Yoo <ap420073@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com, 
	almasrymina@...gle.com, donald.hunter@...il.com, corbet@....net, 
	michael.chan@...adcom.com, andrew+netdev@...n.ch, hawk@...nel.org, 
	ilias.apalodimas@...aro.org, ast@...nel.org, daniel@...earbox.net, 
	john.fastabend@...il.com, dw@...idwei.uk, sdf@...ichev.me, 
	asml.silence@...il.com, brett.creeley@....com, linux-doc@...r.kernel.org, 
	netdev@...r.kernel.org, kory.maincent@...tlin.com, 
	maxime.chevallier@...tlin.com, danieller@...dia.com, hengqi@...ux.alibaba.com, 
	ecree.xilinx@...il.com, przemyslaw.kitszel@...el.com, hkallweit1@...il.com, 
	ahmed.zaki@...el.com, rrameshbabu@...dia.com, idosch@...dia.com, 
	jiri@...nulli.us, bigeasy@...utronix.de, lorenzo@...nel.org, 
	jdamato@...tly.com, aleksander.lobakin@...el.com, kaiyuanz@...gle.com, 
	willemb@...gle.com, daniel.zahka@...il.com
Subject: Re: [PATCH net-next v7 10/10] selftest: net-drv: hds: add test for
 HDS feature

On Tue, Jan 7, 2025 at 12:01 PM Jakub Kicinski <kuba@...nel.org> wrote:
>

Hi Jakub,
Thanks a lot for the review!

> On Fri,  3 Jan 2025 15:03:25 +0000 Taehee Yoo wrote:
> > +    try:
> > +        netnl.rings_set({'header': {'dev-index': cfg.ifindex}, 'hds-thresh': hds_gt})
> > +    except NlError as e:
> > +        if e.error == errno.EOPNOTSUPP:
> > +            raise KsftSkipEx("ring-set not supported by the device")
> > +        ksft_eq(e.error, errno.EINVAL)
> > +    else:
> > +        raise KsftFailEx("exceeded hds-thresh should be failed")
>
> Nice work on the tests! FWIW you could use ksft_raises(NlError) here,
> but this works too. You can leave it as is if you prefer.

Thanks for the suggestion, I will change it after tests!

Thanks a lot,
Taehee Yoo