netdev - Re: [PATCH rdma-next v2 RESEND 2/4] RDMA/bnxt_re: Add Async event handling support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250107152452.GE87447@unreal>
Date: Tue, 7 Jan 2025 17:24:52 +0200
From: Leon Romanovsky <leon@...nel.org>
To: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
Cc: jgg@...pe.ca, linux-rdma@...r.kernel.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, netdev@...r.kernel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch,
	andrew.gospodarek@...adcom.com, selvin.xavier@...adcom.com,
	michael.chan@...adcom.com, pavan.chebbi@...adcom.com
Subject: Re: [PATCH rdma-next v2 RESEND 2/4] RDMA/bnxt_re: Add Async event
 handling support

On Tue, Jan 07, 2025 at 08:15:50AM +0530, Kalesh AP wrote:
> Using the option provided by Ethernet driver, register for FW Async
> event. During probe, while registeriung with Ethernet driver, provide
> the ulp hook 'ulp_async_notifier' for receiving the firmware events.
> 
> Signed-off-by: Selvin Xavier <selvin.xavier@...adcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> ---
>  drivers/infiniband/hw/bnxt_re/bnxt_re.h |  1 +
>  drivers/infiniband/hw/bnxt_re/main.c    | 47 +++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)

<...>

> +static void bnxt_re_net_unregister_async_event(struct bnxt_re_dev *rdev)
> +{
> +	int rc;
> +
> +	if (rdev->is_virtfn)
> +		return;
> +
> +	memset(&rdev->event_bitmap, 0, sizeof(rdev->event_bitmap));
> +	rc = bnxt_register_async_events(rdev->en_dev, &rdev->event_bitmap,
> +					ASYNC_EVENT_CMPL_EVENT_ID_DCB_CONFIG_CHANGE);
> +	if (rc)
> +		ibdev_err(&rdev->ibdev, "Failed to unregister async event");
> +}
> +
> +static void bnxt_re_net_register_async_event(struct bnxt_re_dev *rdev)
> +{
> +	int rc;
> +
> +	if (rdev->is_virtfn)
> +		return;
> +
> +	rdev->event_bitmap |= (1 << ASYNC_EVENT_CMPL_EVENT_ID_DCB_CONFIG_CHANGE);
> +	rc = bnxt_register_async_events(rdev->en_dev, &rdev->event_bitmap,
> +					ASYNC_EVENT_CMPL_EVENT_ID_DCB_CONFIG_CHANGE);
> +	if (rc)
> +		ibdev_err(&rdev->ibdev, "Failed to unregister async event");

s/Failed to unregister async event/Failed to register async event

If it is the only comment, we will get for this series. You don't need to resend, I'll fix it.

Thanks

> +}