netdev - [PATCH 0/6] netfilter: x_tables: Merge xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250107184724.56223-1-egyszeregy@freemail.hu>
Date: Tue,  7 Jan 2025 19:47:18 +0100
From: egyszeregy@...email.hu
To: fw@...len.de,
	pablo@...filter.org,
	lorenzo@...nel.org,
	daniel@...earbox.net,
	leitao@...ian.org,
	amiculas@...co.com,
	kadlec@...filter.org,
	davem@...emloft.net,
	dsahern@...nel.org,
	edumazet@...gle.com,
	kuba@...nel.org,
	pabeni@...hat.com,
	horms@...nel.org,
	netfilter-devel@...r.kernel.org,
	coreteam@...filter.org,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Cc: Benjamin Szőke <egyszeregy@...email.hu>
Subject: [PATCH 0/6] netfilter: x_tables: Merge xt_*.c files which has same name.

From: Benjamin Szőke <egyszeregy@...email.hu>

Merge xt_*.c source files, which has same upper and
lowercase name format. Combining these modules should
provide some decent code size and memory savings.

test-build:
$ mkdir build
$ wget -O ./build/.config https://pastebin.com/raw/teShg1sp
$ make O=./build/ ARCH=x86 -j 16

x86_64-before:
text    data     bss     dec     hex filename
 716     432       0    1148     47c xt_dscp.o
1142     432       0    1574     626 xt_DSCP.o
 593     224       0     817     331 xt_hl.o
 934     224       0    1158     486 xt_HL.o
1099     120       0    1219     4c3 xt_rateest.o
2126     365       4    2495     9bf xt_RATEEST.o
 747     224       0     971     3cb xt_tcpmss.o
2824     352       0    3176     c68 xt_TCPMSS.o
total data: 2373

x86_64-after:
text    data     bss     dec     hex filename
1709     848       0    2557     9fd xt_dscp.o
1352     448       0    1800     708 xt_hl.o
3075     481       4    3560     de8 xt_rateest.o
3423     576       0    3999     f9f xt_tcpmss.o
total data: 2353

Build as a module it can provide 50% reduction in
run-time memory use.

x86_64-before:
$ lsmod
xt_TCPMSS              12288  0
xt_tcpmss              12288  0

x86_64-after:
$ lsmod
xt_tcpmss              12288  0

Benjamin Szőke (6):
  netfilter: x_tables: Format code of xt_*.c files.
  netfilter: x_tables: Merge xt_DSCP.c to xt_dscp.c
  netfilter: x_tables: Merge xt_HL.c to xt_hl.c
  netfilter: x_tables: Merge xt_RATEEST.c to xt_rateest.c
  netfilter: x_tables: Merge xt_TCPMSS.c to xt_tcpmss.c
  netfilter: x_tables: Adjust code style of xt_*.c files.

 net/netfilter/Kconfig      |  84 +++++++++
 net/netfilter/Makefile     |  12 +-
 net/netfilter/xt_DSCP.c    | 161 -----------------
 net/netfilter/xt_HL.c      | 159 -----------------
 net/netfilter/xt_RATEEST.c | 248 --------------------------
 net/netfilter/xt_TCPMSS.c  | 345 ------------------------------------
 net/netfilter/xt_dscp.c    | 159 ++++++++++++++++-
 net/netfilter/xt_hl.c      | 163 +++++++++++++++--
 net/netfilter/xt_rateest.c | 255 +++++++++++++++++++++++++--
 net/netfilter/xt_tcpmss.c  | 352 +++++++++++++++++++++++++++++++++++--
 10 files changed, 972 insertions(+), 966 deletions(-)
 delete mode 100644 net/netfilter/xt_DSCP.c
 delete mode 100644 net/netfilter/xt_HL.c
 delete mode 100644 net/netfilter/xt_RATEEST.c
 delete mode 100644 net/netfilter/xt_TCPMSS.c

-- 
2.43.5